[Infra UI] Asset Details Flyout: Add tooltip with documentation link in metadata summary #162132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennypavlova
added
Team:Infra Monitoring UI - DEPRECATED
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…definition-in-overview-tab
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Comment on lines
+49
to
+50
| tooltipLinkLabel: 'host.ip', | ||
| tooltipLink: 'https://www.elastic.co/guide/en/ecs/current/ecs-host.html#field-host-ip', |
There was a problem hiding this comment.
For now, I think it's ok, but once we start integrating more asset types, we might have to rely on what findInventoryModel(nodeType) returns. ip info might sit in a different field name depending on the asset type. The same goes for the translations.
There was a problem hiding this comment.
Good point, we should revisit this once we have more asset types 👍
jennypavlova
deleted the
1135-infra-ui-show-fields-used-for-metadata-definition-in-overview-tab
branch
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
…in metadata summary (elastic#162132) ## Summary This PR adds a tooltip with a documentation link in the metadata summary inside the asset details overview section. It should appear only if we have defined documentation link so currently only for the `host.ip` field <img width="1918" alt="Screenshot 2023-07-18 at 13 13 25" src="https://github.com/elastic/kibana/assets/14139027/e5ef2067-3a3b-48fd-a395-b763a6832bd1"> ## Storybook <img width="1917" alt="image" src="https://github.com/elastic/kibana/assets/14139027/dfbd0118-b0ff-475b-a545-9e7278815098"> ## Testing - Go to host view and open the asset details flyout for any host - Go to the overview tab - A question mark icon should appear next to the host ip title inside the metadata section - Click on the icon and check the tooltip - the `host.ip` link should open the documentation page for the field in a new tab https://github.com/elastic/kibana/assets/14139027/c83dcefd-34b1-4f61-aa96-b9fd0e6ef07b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a tooltip with a documentation link in the metadata summary inside the asset details overview section. It should appear only if we have defined documentation link so currently only for the
host.ipfieldStorybook
Testing
host.iplink should open the documentation page for the field in a new tabmetadata_tooltip.mov