Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serverless Search] Remove unwanted alterting rule and connector types #162105

Merged
merged 5 commits into from
Jul 19, 2023
Merged

[Serverless Search] Remove unwanted alterting rule and connector types #162105

merged 5 commits into from
Jul 19, 2023

Conversation

sphilipse
Copy link
Member

Summary

This moves alerting in Serverless Search to the Stack Management alerting page, and removes

To remove these rule types, I had to disable the observability, securitySolution, uptime, monitoring and infra plugins and make sure that their server plugins (not just the frontend plugins) respected the enabled: false flag.

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.10.0 labels Jul 18, 2023
@sphilipse sphilipse requested review from a team as code owners July 18, 2023 06:23
@sphilipse sphilipse requested a review from a team July 18, 2023 06:23
@sphilipse sphilipse requested a review from a team as a code owner July 18, 2023 06:23
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jul 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@sphilipse sphilipse requested a review from a team as a code owner July 18, 2023 07:26
@pgayvallet
Copy link
Contributor

To remove these rule types, I had to disable the observability, securitySolution, uptime, monitoring and infra plugins and make sure that their server plugins (not just the frontend plugins) respected the enabled: false flag

Could you (if not done already) check with each team owning those individual plugins that the config changes done in this PR is fine with them?

@sphilipse
Copy link
Member Author

To remove these rule types, I had to disable the observability, securitySolution, uptime, monitoring and infra plugins and make sure that their server plugins (not just the frontend plugins) respected the enabled: false flag

Could you (if not done already) check with each team owning those individual plugins that the config changes done in this PR is fine with them?

I'm checking with the teams whose configs I changed (uptime, monitoring and infra). Disabling Observability and SecuritySolution plugins in Serverless Search doesn't need that check, it's aligned with the product direction for Serverless Search. Users wanting to use Observability or SecuritySolution in Serverless should spin up a Serverless Observability or Serverless Security project instead of a Serverless Search one.

@sphilipse sphilipse removed the request for review from a team July 18, 2023 10:16
@shahzad31 shahzad31 removed the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jul 18, 2023
CoenWarmer
CoenWarmer approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@CoenWarmer CoenWarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sphilipse
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
infra 41 42 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
serverlessSearch 29.6KB 29.6KB +35.0B
Unknown metric groups

API count

id before after diff
infra 44 45 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tonyghiani
tonyghiani reviewed Jul 19, 2023
View reviewed changes
x-pack/plugins/infra/common/plugin_config_types.ts
@@ -14,6 +14,7 @@ export interface InfraConfig {
group_by_page_size: number;
};
};
enabled: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this flag need to be exposed to the client public config for any reason or is it only necessary server side?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s only necessary on the server side, Kibana will pick it up and skip initializing the entire plug-in (server and client).

tonyghiani
tonyghiani approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra config LGTM!

@sphilipse sphilipse merged commit 0a6b5e9 into elastic:main Jul 19, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 19, 2023
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
@sphilipse
[Serverless Search] Remove unwanted alterting rule and connector types (
14d5cac 
elastic#162105)

## Summary

This moves alerting in Serverless Search to the Stack Management
alerting page, and removes

To remove these rule types, I had to disable the observability,
securitySolution, uptime, monitoring and infra plugins and make sure
that their server plugins (not just the frontend plugins) respected the
`enabled: false` flag.
@mikecote mikecote mentioned this pull request Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyghiani tonyghiani tonyghiani approved these changes

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@CoenWarmer CoenWarmer CoenWarmer approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sphilipse @elasticmachine @pgayvallet @kibanamachine @kibana-ci @CoenWarmer @TattdCodeMonkey @tonyghiani @shahzad31