Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DE][EQL] Remove negative correlation UI tour #162102

Merged
merged 1 commit into from
Jul 18, 2023
Merged

[DE][EQL] Remove negative correlation UI tour #162102

merged 1 commit into from
Jul 18, 2023

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Jul 18, 2023 •
edited by kibanamachine
Loading

Removing tour highlighting negative rule correlation.

@yctercero yctercero added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Feature:Detection Alerts Security Solution Detection Alerts Feature v8.9.0 Team:Detection Engine Security Solution Detection Engine Area v8.10.0 v8.9.1 labels Jul 18, 2023
@yctercero yctercero self-assigned this Jul 18, 2023
@yctercero yctercero requested a review from a team as a code owner July 18, 2023 01:10
@yctercero yctercero requested a review from xcrzx July 18, 2023 01:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@yctercero yctercero enabled auto-merge (squash) July 18, 2023 01:11
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Tests #3 / Alert details expandable flyout right panel overview tab insights section should display threat intelligence section
  • [job] [logs] Defend Workflows Cypress Tests #1 / Endpoint Policy Response from Fleet Agent Details page should display policy response with errors

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4314 4312 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.8MB 9.8MB -1.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 53.6KB 53.5KB -122.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@yctercero yctercero merged commit ce0e6b3 into elastic:main Jul 18, 2023
@kibanamachine kibanamachine mentioned this pull request Jul 18, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 18, 2023
@yctercero
[DE][EQL] Remove negative correlation UI tour (elastic#162102)
1cff6f3 
Removing tour highlighting negative rule correlation.

(cherry picked from commit ce0e6b3)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 18, 2023
@kibanamachine @yctercero
[8.9] [DE][EQL] Remove negative correlation UI tour (#162102) (#162103)
eca361c 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[DE][EQL] Remove negative correlation UI tour
(#162102)](#162102)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yara
Tercero","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-18T03:20:45Z","message":"[DE][EQL]
Remove negative correlation UI tour (#162102)\n\nRemoving tour
highlighting negative rule
correlation.","sha":"ce0e6b3497abc1d1d4e11e86736a2c893ef87d0a","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections
and Resp","Feature:Detection Alerts","v8.9.0","Team:Detection
Engine","v8.10.0","v8.9.1"],"number":162102,"url":"https://github.com/elastic/kibana/pull/162102","mergeCommit":{"message":"[DE][EQL]
Remove negative correlation UI tour (#162102)\n\nRemoving tour
highlighting negative rule
correlation.","sha":"ce0e6b3497abc1d1d4e11e86736a2c893ef87d0a"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162102","number":162102,"mergeCommit":{"message":"[DE][EQL]
Remove negative correlation UI tour (#162102)\n\nRemoving tour
highlighting negative rule
correlation.","sha":"ce0e6b3497abc1d1d4e11e86736a2c893ef87d0a"}}]}]
BACKPORT-->

Co-authored-by: Yara Tercero <[email protected]>
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
@yctercero
[DE][EQL] Remove negative correlation UI tour (elastic#162102)
48162fc 
Removing tour highlighting negative rule correlation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplumlee dplumlee dplumlee approved these changes

@xcrzx xcrzx Awaiting requested review from xcrzx xcrzx was automatically assigned from elastic/security-detection-rule-management

Assignees

@yctercero yctercero

Labels
Feature:Detection Alerts Security Solution Detection Alerts Feature release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team v8.9.0 v8.9.1 v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yctercero @elasticmachine @kibana-ci @kibanamachine @dplumlee