[Security Solution][Fix] Empty Alert Table when upgrading from 8.8.x -> 8.9 #162063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logeekal
added
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
logeekal
added
release_note:skip
logeekal
commented
Jul 17, 2023
| @@ -100,7 +112,7 @@ export const migrateAlertTableStateToTriggerActionsState = ( | |||
| sort: legacyDataTableState[tableKey].sort.map((sortCandidate) => ({ | |||
| [sortCandidate.columnId]: { order: sortCandidate.sortDirection }, | |||
| })), | |||
| visibleColumns: legacyDataTableState[tableKey].columns.map((c) => c.id), | |||
| visibleColumns: legacyDataTableState[tableKey].columns, | |||
There was a problem hiding this comment.
| return; | ||
| } | ||
|
|
||
| if ('visibleColumns' in alertTableData) { |
There was a problem hiding this comment.
Can we have one more early exit here?
const nonCompliant = alertTableData.visibleColumns.some(val => typeof val !== 'string')
if (!nonCompliant) return
... or this if you prefer
if (nonCompliant) {
alertTableData.visibleColumns.map(...)
}
Right now the map will most likely run every time someone loads the table for every version after this
There was a problem hiding this comment.
You are right.. made these changes with a little tweak.
| const visibleColumns = | ||
| alertTableData.visibleColumns as DataTableState['dataTable']['tableById'][string]['columns']; | ||
| const v89CompliantFormat = visibleColumns.every((val: unknown) => typeof val === 'string'); | ||
| if (v89CompliantFormat) { |
There was a problem hiding this comment.
Sweet, this works! 👍🏾
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
michaelolo24
approved these changes
Jul 17, 2023
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
logeekal
added a commit
to logeekal/kibana
that referenced
this pull request
Jul 18, 2023
…-> 8.9 (elastic#162063) ## Summary When users upgrade from `8.8.x` -> `8.9` version, users observe empty table as shown below.  Below are steps to reproduce this issue and test it: 1. Boot [email protected] 2. Clear Local storage. 3. Go to Security -> Alerts 4. Add Columns `_id` or any other column 5. Upgrade to `8.9` 6. The table will empty as shown in above screenshot. ## Fix This fix saperates out the migraton from 8.7 -> 8.8 and add a new migration for upgrading from 8.8 -> 8.9 `migrateAlertTableStateToTriggerActionsState` migrates table from `v8.7 -> v8.8`, `migrateTriggerActionsVisibleColumnsAlertTable88xTo89` migrates from `v8.8.x` -> `v8.9` Combining both of them may lead to issues when users are migrating from `v8.7` -> `v8.9` or `v8.8` -> `v8.9` (cherry picked from commit 0516cae)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 18, 2023
…-> 8.9 (elastic#162063) ## Summary When users upgrade from `8.8.x` -> `8.9` version, users observe empty table as shown below.  Below are steps to reproduce this issue and test it: 1. Boot [email protected] 2. Clear Local storage. 3. Go to Security -> Alerts 4. Add Columns `_id` or any other column 5. Upgrade to `8.9` 6. The table will empty as shown in above screenshot. ## Fix This fix saperates out the migraton from 8.7 -> 8.8 and add a new migration for upgrading from 8.8 -> 8.9 `migrateAlertTableStateToTriggerActionsState` migrates table from `v8.7 -> v8.8`, `migrateTriggerActionsVisibleColumnsAlertTable88xTo89` migrates from `v8.8.x` -> `v8.9` Combining both of them may lead to issues when users are migrating from `v8.7` -> `v8.9` or `v8.8` -> `v8.9` (cherry picked from commit 0516cae)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 18, 2023
…8.8.x -> 8.9 (#162063) (#162120) # Backport This will backport the following commits from `main` to `8.9`: - [[Security Solution][Fix] Empty Alert Table when upgrading from 8.8.x -> 8.9 (#162063)](#162063) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-18T08:57:12Z","message":"[Security Solution][Fix] Empty Alert Table when upgrading from 8.8.x -> 8.9 (#162063)\n\n## Summary\r\n\r\nWhen users upgrade from `8.8.x` -> `8.9` version, users observe empty\r\ntable as shown below.\r\n\r\n\r\n\r\n\r\n\r\nBelow are steps to reproduce this issue and test it:\r\n\r\n1. Boot [email protected]\r\n2. Clear Local storage.\r\n3. Go to Security -> Alerts\r\n4. Add Columns `_id` or any other column \r\n5. Upgrade to `8.9`\r\n6. The table will empty as shown in above screenshot.\r\n\r\n\r\n## Fix\r\n\r\nThis fix saperates out the migraton from 8.7 -> 8.8 and add a new\r\nmigration for upgrading from 8.8 -> 8.9\r\n\r\n`migrateAlertTableStateToTriggerActionsState` migrates table from `v8.7\r\n-> v8.8`,\r\n\r\n`migrateTriggerActionsVisibleColumnsAlertTable88xTo89` migrates from\r\n`v8.8.x` -> `v8.9`\r\n\r\nCombining both of them may lead to issues when users are migrating from\r\n`v8.7` -> `v8.9` or `v8.8` -> `v8.9`","sha":"0516caed1de3b72efa3f5c1282975c34962f7999","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Team:Threat Hunting:Investigations","v8.9.0","v8.10.0"],"number":162063,"url":"https://github.com/elastic/kibana/pull/162063","mergeCommit":{"message":"[Security Solution][Fix] Empty Alert Table when upgrading from 8.8.x -> 8.9 (#162063)\n\n## Summary\r\n\r\nWhen users upgrade from `8.8.x` -> `8.9` version, users observe empty\r\ntable as shown below.\r\n\r\n\r\n\r\n\r\n\r\nBelow are steps to reproduce this issue and test it:\r\n\r\n1. Boot [email protected]\r\n2. Clear Local storage.\r\n3. Go to Security -> Alerts\r\n4. Add Columns `_id` or any other column \r\n5. Upgrade to `8.9`\r\n6. The table will empty as shown in above screenshot.\r\n\r\n\r\n## Fix\r\n\r\nThis fix saperates out the migraton from 8.7 -> 8.8 and add a new\r\nmigration for upgrading from 8.8 -> 8.9\r\n\r\n`migrateAlertTableStateToTriggerActionsState` migrates table from `v8.7\r\n-> v8.8`,\r\n\r\n`migrateTriggerActionsVisibleColumnsAlertTable88xTo89` migrates from\r\n`v8.8.x` -> `v8.9`\r\n\r\nCombining both of them may lead to issues when users are migrating from\r\n`v8.7` -> `v8.9` or `v8.8` -> `v8.9`","sha":"0516caed1de3b72efa3f5c1282975c34962f7999"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162063","number":162063,"mergeCommit":{"message":"[Security Solution][Fix] Empty Alert Table when upgrading from 8.8.x -> 8.9 (#162063)\n\n## Summary\r\n\r\nWhen users upgrade from `8.8.x` -> `8.9` version, users observe empty\r\ntable as shown below.\r\n\r\n\r\n\r\n\r\n\r\nBelow are steps to reproduce this issue and test it:\r\n\r\n1. Boot [email protected]\r\n2. Clear Local storage.\r\n3. Go to Security -> Alerts\r\n4. Add Columns `_id` or any other column \r\n5. Upgrade to `8.9`\r\n6. The table will empty as shown in above screenshot.\r\n\r\n\r\n## Fix\r\n\r\nThis fix saperates out the migraton from 8.7 -> 8.8 and add a new\r\nmigration for upgrading from 8.8 -> 8.9\r\n\r\n`migrateAlertTableStateToTriggerActionsState` migrates table from `v8.7\r\n-> v8.8`,\r\n\r\n`migrateTriggerActionsVisibleColumnsAlertTable88xTo89` migrates from\r\n`v8.8.x` -> `v8.9`\r\n\r\nCombining both of them may lead to issues when users are migrating from\r\n`v8.7` -> `v8.9` or `v8.8` -> `v8.9`","sha":"0516caed1de3b72efa3f5c1282975c34962f7999"}}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <[email protected]>
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
…-> 8.9 (elastic#162063) ## Summary When users upgrade from `8.8.x` -> `8.9` version, users observe empty table as shown below.  Below are steps to reproduce this issue and test it: 1. Boot [email protected] 2. Clear Local storage. 3. Go to Security -> Alerts 4. Add Columns `_id` or any other column 5. Upgrade to `8.9` 6. The table will empty as shown in above screenshot. ## Fix This fix saperates out the migraton from 8.7 -> 8.8 and add a new migration for upgrading from 8.8 -> 8.9 `migrateAlertTableStateToTriggerActionsState` migrates table from `v8.7 -> v8.8`, `migrateTriggerActionsVisibleColumnsAlertTable88xTo89` migrates from `v8.8.x` -> `v8.9` Combining both of them may lead to issues when users are migrating from `v8.7` -> `v8.9` or `v8.8` -> `v8.9`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When users upgrade from
8.8.x->8.9version, users observe empty table as shown below.Below are steps to reproduce this issue and test it:
_idor any other column8.9Fix
This fix saperates out the migraton from 8.7 -> 8.8 and add a new migration for upgrading from 8.8 -> 8.9
migrateAlertTableStateToTriggerActionsStatemigrates table fromv8.7 -> v8.8,migrateTriggerActionsVisibleColumnsAlertTable88xTo89migrates fromv8.8.x->v8.9Combining both of them may lead to issues when users are migrating from
v8.7->v8.9orv8.8->v8.9