[Security Solution] Expandable flyout - add rule preview skeleton #161999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christineweng
force-pushed
the
6999-rule-preview
branch
from
f9652bb
to
d3ee72c
Compare
christineweng
force-pushed
the
6999-rule-preview
branch
from
d3ee72c
to
619b450
Compare
christineweng
added
release_note:feature
PhilippeOberti
requested changes
Jul 24, 2023
packages/kbn-expandable-flyout/src/components/preview_section.tsx
Outdated
Show resolved
Hide resolved
packages/kbn-expandable-flyout/src/components/preview_section.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/flyout/preview/components/rule_preview.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/flyout/preview/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/flyout/preview/context.tsx
Outdated
Show resolved
Hide resolved
christineweng
force-pushed
the
6999-rule-preview
branch
from
16da266
to
27b7855
Compare
…-ref HEAD~1..HEAD --fix'
PhilippeOberti
approved these changes
Jul 27, 2023
packages/kbn-expandable-flyout/src/components/preview_section.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
…astic#161999) ## Summary This PR adds a rule preview panel to the expandable flyout: - Preview panel skeleton is added, now we can open a preview on top of right section of flyout - Go to rule details button is replaced by a button that will open a rule preview panel - The rule preview contains placeholder sections (About, Definition, Schedule) and footer with a link to rule details page  **How to test** - add `xpack.securitySolution.enableExperimental: ['securityFlyoutEnabled']` to the `kibana.dev.json` file - go to the Alerts page, and click on the expand detail button on any row of the table - click on `Overview`, `About`, then `Rule summary` ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>
2 tasks
christineweng
added a commit
that referenced
this pull request
Aug 10, 2023
## Summary This PR is part 2 of adding a rule preview panel to the expandable flyout. PR (#161999) adds the preview skeleton, and this PR populates the actual content related to rule details: Expandable flyout: - Updated title to include `created by` and `updated by` timestamps, and rule switch button - Added contents for about, define, schedule and actions (if any) - Added a hook to fetch data for rule switch button - logic mimics rule details page (`~/security_solution/public/detection_engine/rule_details_ui/pages/rule_details/index.tsx`) Rule & detections: - Added `isPanelView` option allow rendering rule details in smaller font, so that it can fit in panel view - Minor UI updates to gutter sizes and spacing to accommodate long text - Extracted `createdBy` and `updatedBy` to `~/security_solution/public/detections/components/rules/rule_info` to be shared between rule details page and flyout  **How to test** - add `xpack.securitySolution.enableExperimental: ['securityFlyoutEnabled']` to the `kibana.dev.json` file - go to the Alerts page, and click on the expand detail button on any row of the table - click on Overview, About, view Rule Summary, the rule preview panel should pop up ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a rule preview panel to the expandable flyout:
How to test
xpack.securitySolution.enableExperimental: ['securityFlyoutEnabled']to thekibana.dev.jsonfileOverview,About, thenRule summaryChecklist