[Serverless nav] Update footer + project settings cloud links #161971

sebelga · 2023-07-14T13:52:59Z

In this PR I've added support for a new "cloudLinkId" property on the navigation node definition. If the kibana.yml config has been set for the cloud link it will render in the left nav. If not it won't render.

I've also added support for a new type of navigation node: a top level "group" that renders as a "link" and not as an accordion header. As per the design, this allows us to render the Developer tools menu item.

I've updated the "search" and "observability" navigation tree to include the cloud links and the developer tools link. For the "search" I've removed the developer tools that was in the body.

How to test

Add the following config in the serverless.yml file

xpack.cloud.performance_url: "/performance/"
xpack.cloud.users_and_roles_url: "/users-and-roles/"

Start a serverless project (e.g. yarn serverless oblt)

Partially fixes #160942 (blocked by #162127)

…fix'

…ana into project-settings-cloud-links

…oud-links

x-pack/plugins/serverless_search/public/layout/nav.tsx

config/serverless.yml

elasticmachine · 2023-07-17T08:10:13Z

Pinging @elastic/appex-sharedux (Team:SharedUX)

azasypkin

Changes in core_plugins/rendering.ts LGTM, left a question regarding trailing slashes.

config/serverless.yml

sebelga · 2023-07-17T11:05:41Z

x-pack/plugins/serverless_search/public/layout/nav.tsx

@@ -52,9 +46,19 @@ const navigationTree: NavigationTreeDefinition = {
            },
            {
              link: 'dashboards',
+              getIsActive: ({ pathNameSerialized, prepend }) => {


I added this to maintain the navigation active state when going from the list -> detailed view

sebelga · 2023-07-17T11:05:57Z

x-pack/plugins/serverless_search/public/layout/nav.tsx

            },
            {
              link: 'visualize',
+              getIsActive: ({ pathNameSerialized, prepend }) => {


I added this to maintain the navigation active state when going from the list to the different visualizations detailed view

Dosant

Lgtm 👍
And nice other smaller fixes 👏

…oud-links

x-pack/plugins/serverless_search/public/layout/nav.tsx

…oud-links

packages/shared-ux/chrome/navigation/src/ui/components/group_as_link.tsx

x-pack/plugins/serverless_observability/public/components/side_navigation/index.tsx

kpatticha

oblt changes LGTM. Thanks for the additional fixes and improvements 🥳

We'll inject them from cloud. Issue elastic#162127

sebelga · 2023-07-18T11:09:27Z

Thanks for the review @kpatticha !

kibana-ci · 2023-07-18T12:00:37Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`serverlessObservability`	41	43	+2
`serverlessSearch`	90	92	+2
total			+4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/core-chrome-browser`	67	66	-1
`@kbn/shared-ux-chrome-navigation`	36	37	+1
`cloud`	13	15	+2
total			+2

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`@kbn/core-chrome-browser`	0	1	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cloud`	5.2KB	5.4KB	+158.0B
`core`	360.6KB	360.8KB	+170.0B
`serverlessObservability`	22.7KB	26.0KB	+3.3KB
`serverlessSearch`	26.0KB	29.4KB	+3.4KB
total			+7.0KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/shared-ux-chrome-navigation`	45	46	+1
`cloud`	61	65	+4
total			+5

ESLint disabled line counts

id	before	after	diff
`@kbn/shared-ux-chrome-navigation`	4	5	+1

Total ESLint disabled count

id	before	after	diff
`@kbn/shared-ux-chrome-navigation`	4	5	+1

History

💚 Build #143093 succeeded 40b9c04
💚 Build #142934 succeeded 247d057
💚 Build #142793 succeeded 98253a4
💔 Build #142727 failed d91fbea
💔 Build #142618 failed a3df9fb
💔 Build #142580 failed 113aa67

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sebelga

sebelga · 2023-07-18T13:21:48Z

@TattdCodeMonkey I reverted the change. Can you have another look? Cheers!

…c#161971)

sebelga added 15 commits July 14, 2023 14:49

Allow cloudLink to be passed in nav node

23d765b

Add cloud config for new URLs

e6d2b30

Update observability nav to include links

21cf3ca

Add urls to cloud start contract

e47a002

Add missing i18n

9997866

Add project settings group to serverless es

ecdbf63

Don't force collapsed state by default

7c5c20f

Improve comment

9e3208c

Update GetApi type to retrieve active state

47dc8f5

Update navs to set active state in details views

80c564d

Fix TS issue

4f9097c

Custom render group with no children with a link

fe0bda0

Update default navigation to include Developer tools link

e817610

Fix issue when active node is at root level of the tree

6f98ab2

Add dev tools link to search and observability

e394800

sebelga self-assigned this Jul 14, 2023

sebelga added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Project:Serverless Work as part of the Serverless project for its initial release Project:Serverless MVP labels Jul 14, 2023

kibanamachine and others added 7 commits July 14, 2023 13:59

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

113aa67

…fix'

Update storybook to render cloud links

fda487c

Add jest test for cloud links

e31f70c

Merge branch 'project-settings-cloud-links' of github.com:sebelga/kib…

a3df9fb

…ana into project-settings-cloud-links

Remove old dev tools menu

d91fbea

Merge remote-tracking branch 'upstream/main' into project-settings-cl…

b859014

…oud-links

Add config to test

b900e98

sebelga commented Jul 17, 2023

View reviewed changes

x-pack/plugins/serverless_search/public/layout/nav.tsx Outdated Show resolved Hide resolved

Add links in serverless.yml

98253a4

sebelga commented Jul 17, 2023

View reviewed changes

config/serverless.yml Outdated Show resolved Hide resolved

sebelga marked this pull request as ready for review July 17, 2023 08:10

sebelga requested a review from Dosant July 17, 2023 08:11

sebelga added the release_note:skip Skip the PR/issue when compiling release notes label Jul 17, 2023

pgayvallet approved these changes Jul 17, 2023

View reviewed changes

azasypkin approved these changes Jul 17, 2023

View reviewed changes

config/serverless.yml Outdated Show resolved Hide resolved

sebelga commented Jul 17, 2023

View reviewed changes

Dosant approved these changes Jul 17, 2023

View reviewed changes

sebelga added 2 commits July 17, 2023 16:28

Merge remote-tracking branch 'upstream/main' into project-settings-cl…

b1c9d44

…oud-links

Remove trailing slash

247d057

TattdCodeMonkey requested changes Jul 17, 2023

View reviewed changes

x-pack/plugins/serverless_search/public/layout/nav.tsx Outdated Show resolved Hide resolved

sebelga added 2 commits July 18, 2023 08:57

Merge remote-tracking branch 'upstream/main' into project-settings-cl…

5cbed96

…oud-links

Revert change to serverless search nav

f8a1af9

sebelga requested a review from TattdCodeMonkey July 18, 2023 08:03

Revert change to obs service type

40b9c04

kpatticha reviewed Jul 18, 2023

View reviewed changes

packages/shared-ux/chrome/navigation/src/ui/components/group_as_link.tsx Show resolved Hide resolved

kpatticha reviewed Jul 18, 2023

View reviewed changes

x-pack/plugins/serverless_observability/public/components/side_navigation/index.tsx Show resolved Hide resolved

kpatticha approved these changes Jul 18, 2023

View reviewed changes

Remove static cloud link

de41cd2

We'll inject them from cloud. Issue elastic#162127

sebelga enabled auto-merge (squash) July 18, 2023 11:04

sebelga mentioned this pull request Jul 18, 2023

[Serverless] Add navigation functional tests #161856

Merged

TattdCodeMonkey approved these changes Jul 18, 2023

View reviewed changes

sebelga merged commit 209d353 into elastic:main Jul 18, 2023

kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jul 18, 2023

sebelga deleted the project-settings-cloud-links branch July 18, 2023 13:49

ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023

[Serverless nav] Update footer + project settings cloud links (elasti…

d2430e0

…c#161971)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Serverless nav] Update footer + project settings cloud links #161971

[Serverless nav] Update footer + project settings cloud links #161971

sebelga commented Jul 14, 2023 •

edited

Loading

elasticmachine commented Jul 17, 2023

azasypkin left a comment

sebelga Jul 17, 2023

sebelga Jul 17, 2023

Dosant left a comment

kpatticha left a comment

sebelga commented Jul 18, 2023

kibana-ci commented Jul 18, 2023

API count

ESLint disabled line counts

Total ESLint disabled count

sebelga commented Jul 18, 2023

[Serverless nav] Update footer + project settings cloud links #161971

[Serverless nav] Update footer + project settings cloud links #161971

Conversation

sebelga commented Jul 14, 2023 • edited Loading

How to test

elasticmachine commented Jul 17, 2023

azasypkin left a comment

Choose a reason for hiding this comment

sebelga Jul 17, 2023

Choose a reason for hiding this comment

sebelga Jul 17, 2023

Choose a reason for hiding this comment

Dosant left a comment

Choose a reason for hiding this comment

kpatticha left a comment

Choose a reason for hiding this comment

sebelga commented Jul 18, 2023

kibana-ci commented Jul 18, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Public APIs missing exports

Page load bundle

API count

ESLint disabled line counts

Total ESLint disabled count

History

sebelga commented Jul 18, 2023

sebelga commented Jul 14, 2023 •

edited

Loading