Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Hide components when there is no support from agents #161970

Merged
merged 5 commits into from
Jul 20, 2023

Conversation

gbamparop
Copy link
Contributor

@gbamparop gbamparop commented Jul 14, 2023

Changes

  • Hide the top five erroneous transactions table in the errors details page for OTel agents and Elastic RUM agent
  • Hide the top five errors table in the transaction details page for OTel agents and Elastic RUM agent
  • Hide the transactions breakdown chart in the service overview, transactions, and transaction detail pages for OTel agents

Elastic APM agent

Screen.Recording.2023-07-20.at.09.07.31.mov

OTel agent

Screen.Recording.2023-07-20.at.09.08.32.mov

Elastic RUM agent

Screen.Recording.2023-07-20.at.09.09.23.mov

Closes #161963

@gbamparop gbamparop requested a review from a team as a code owner July 14, 2023 13:41
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 14, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@gbamparop
Copy link
Contributor Author

We can have an e2e test for this, I'll create a follow up issue as we don't target OTel agents now AFAICT.

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Don't you also need to remove the table from the transaction details page? (Top 5 Errors table)

@gbamparop
Copy link
Contributor Author

Thanks! Don't you also need to remove the table from the transaction details page? (Top 5 Errors table)

That's a good point. I can remove that too. The UI changes though as the failed transaction rate will take all the horizontal space for OTel agents. Same with the errors details page and the error occurrences chart (see description). @boriskirov WDYT?

Elastic APM
image

OTel
image

@gbamparop gbamparop changed the title [APM] Hide the top five affected transactions table for OTel agents [APM] Hide components when there is no support from agents Jul 20, 2023
@gbamparop
Copy link
Contributor Author

That's a good point. I can remove that too. The UI changes though as the failed transaction rate will take all the horizontal space for OTel agents. Same with the errors details page and the error occurrences chart (see description). @boriskirov WDYT?

We have agreed offline to hide the components in these cases.

@gbamparop gbamparop requested a review from sorenlouv July 20, 2023 08:11
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.6MB 3.6MB +148.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gbamparop gbamparop merged commit c1fc644 into elastic:main Jul 20, 2023
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jul 20, 2023
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
…61970)

### Changes
- Hide the top five erroneous transactions table in the errors details
page for OTel agents and Elastic RUM agent
- Hide the top five errors table in the transaction details page for
OTel agents and Elastic RUM agent
- Hide the transactions breakdown chart in the service overview,
transactions, and transaction detail pages for OTel agents

### Elastic APM agent

https://github.com/elastic/kibana/assets/5831975/dc2a5051-094b-466c-821d-67da1611be6c

### OTel agent

https://github.com/elastic/kibana/assets/5831975/05eba515-98da-4afd-85c3-c7f58704ea6b

### Elastic RUM agent

https://github.com/elastic/kibana/assets/5831975/a283c657-a703-43a7-a02d-c4d326205c6a

Closes elastic#161963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:fix Team:APM All issues that need APM UI Team support v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Hide "Top 5 errors/transactions" tables
6 participants