-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Hide components when there is no support from agents #161970
[APM] Hide components when there is no support from agents #161970
Conversation
Pinging @elastic/apm-ui (Team:APM) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
We can have an e2e test for this, I'll create a follow up issue as we don't target OTel agents now AFAICT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Don't you also need to remove the table from the transaction details page? (Top 5 Errors table)
That's a good point. I can remove that too. The UI changes though as the failed transaction rate will take all the horizontal space for OTel agents. Same with the errors details page and the error occurrences chart (see description). @boriskirov WDYT? |
We have agreed offline to hide the components in these cases. |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
…61970) ### Changes - Hide the top five erroneous transactions table in the errors details page for OTel agents and Elastic RUM agent - Hide the top five errors table in the transaction details page for OTel agents and Elastic RUM agent - Hide the transactions breakdown chart in the service overview, transactions, and transaction detail pages for OTel agents ### Elastic APM agent https://github.com/elastic/kibana/assets/5831975/dc2a5051-094b-466c-821d-67da1611be6c ### OTel agent https://github.com/elastic/kibana/assets/5831975/05eba515-98da-4afd-85c3-c7f58704ea6b ### Elastic RUM agent https://github.com/elastic/kibana/assets/5831975/a283c657-a703-43a7-a02d-c4d326205c6a Closes elastic#161963
Changes
Elastic APM agent
Screen.Recording.2023-07-20.at.09.07.31.mov
OTel agent
Screen.Recording.2023-07-20.at.09.08.32.mov
Elastic RUM agent
Screen.Recording.2023-07-20.at.09.09.23.mov
Closes #161963