-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] expandable flyout - add status to flyout header #161942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:feature
Makes this part of the condensed release notes
Team:Threat Hunting:Investigations
Security Solution Investigations Team
v8.10.0
labels
Jul 14, 2023
PhilippeOberti
force-pushed
the
expanded-flyout-7002
branch
from
July 14, 2023 11:07
113c5ce
to
768b331
Compare
PhilippeOberti
force-pushed
the
expanded-flyout-7002
branch
2 times, most recently
from
July 14, 2023 12:59
efbe353
to
4a8c1aa
Compare
christineweng
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Desk tested and LGTM! Left some nits on casting and ui spacing.
x-pack/plugins/security_solution/public/flyout/right/components/header_title.test.tsx
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/flyout/right/components/status.stories.tsx
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/flyout/right/components/header_title.tsx
Outdated
Show resolved
Hide resolved
PhilippeOberti
force-pushed
the
expanded-flyout-7002
branch
from
July 17, 2023 08:25
4a8c1aa
to
28a8fb4
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:feature
Makes this part of the condensed release notes
Team:Threat Hunting:Investigations
Security Solution Investigations Team
v8.10.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: this PR needs to be merged first
Summary
This PR introduces the alert status to the expandable flyout right section header.
The status component is reused from the existing flyout, and keeps the same behavior:
Mark as open
Mark as closed
Mark as acknowledged
Screen.Recording.2023-07-14.at.12.22.38.PM.mov
https://github.com/elastic/security-team/issues/7002
Checklist
Delete any items that are not applicable to this PR.