Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] expandable flyout - add status to flyout header #161942

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

PhilippeOberti
Copy link
Contributor

Notes: this PR needs to be merged first

Summary

This PR introduces the alert status to the expandable flyout right section header.
The status component is reused from the existing flyout, and keeps the same behavior:

  • click on the arrow opens a dropdown with 3 options
    • Mark as open
    • Mark as closed
    • Mark as acknowledged
  • when option in the dropdown is clicked, the flyout is being closed (this is because the UI doesn't update automatically, one day we'll fix this issue - see this ticket and this one)

Screenshot 2023-07-14 at 12 22 20 PM

Screen.Recording.2023-07-14.at.12.22.38.PM.mov

https://github.com/elastic/security-team/issues/7002

Checklist

Delete any items that are not applicable to this PR.

@PhilippeOberti PhilippeOberti requested review from a team as code owners July 14, 2023 10:31
@PhilippeOberti PhilippeOberti added release_note:feature Makes this part of the condensed release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.10.0 labels Jul 14, 2023
@PhilippeOberti PhilippeOberti removed request for a team July 14, 2023 11:07
@PhilippeOberti PhilippeOberti force-pushed the expanded-flyout-7002 branch 2 times, most recently from efbe353 to 4a8c1aa Compare July 14, 2023 12:59
Copy link
Contributor

@christineweng christineweng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Desk tested and LGTM! Left some nits on casting and ui spacing.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4272 4273 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.8MB 9.8MB +2.6KB

History

  • 💛 Build #142549 was flaky 4a8c1aab9e89b68da3344bb3ca1e4a1908bc275e
  • 💔 Build #142521 failed efbe353932b4c0463fa3254b7b694498820d0ee5
  • 💔 Build #142499 failed 28f71c908074f3e7057fe9ad78d156b0eb9a069d
  • 💔 Build #142484 failed 113c5cef09a12ff48cf3b8dc8a1b76634241579c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@PhilippeOberti PhilippeOberti merged commit 68b8ac3 into main Jul 18, 2023
@PhilippeOberti PhilippeOberti deleted the expanded-flyout-7002 branch July 18, 2023 07:23
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants