-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated node-sass with sass #161813
Replace deprecated node-sass with sass #161813
Conversation
Also, removing this would save us from having to build and serve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this! Have we considered using sass-embedded instead of sass
?
It looks like there's almost a 3x slowdown in performance between node-sass and sass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @jbudz here. We should experiment to use sass-embedded instead of sass
. It offers the same upsides for us ( 1- move ahead from a legacy thing ; 2 - include prebuilds for every important architecture) while it should preserve the previous performance on builds
ad0c75f
to
9724bd9
Compare
I'm just worried this is adding a performance penalty to a such important job step like |
node-sass is still under maintenance. If there's a must-have feature I think we can make the case for upgrading, but in isolation I don't see a benefit over the significant time increase in plugin builds. Overall it looks like +4 minutes on CI, and a matching (and less parallel) experience for development. It is good to know we can upgrade now though, if needed. The previous attempt didn't work out #61722. |
I agree with Jon here. I think this is good work but the benefits of doing it now without upgrading the webpack to v5 so we can use the embedded version don't pay the costs (CI overhead) IMHO. It's probably better to hold off this PR until that moment and then we can move on with it |
…ode-sass # Conflicts: # yarn.lock
woooooah, great news @mistic! |
@patrykkopycinski can we revive this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…ode-sass # Conflicts: # package.json # yarn.lock
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
@patrykkopycinski This was reverted with 3def20e. See https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/3735 for build failures, and https://buildkite.com/elastic/kibana-pull-request/builds/184823#018c8d10-8206-4937-9122-e13d5616f81a for the followup failures after the output style was changed. |
## Summary The previous PR elastic#161813 was reverted due to the broken webpack config elastic@eef1afc --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jon <jon@elastic.co> (cherry picked from commit d4be2a3)
The previous PR elastic#161813 was reverted due to the broken webpack config elastic@eef1afc --------- Co-authored-by: Tiago Costa <tiago.costa@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jon <jon@elastic.co>
Summary
https://sass-lang.com/blog/libsass-is-deprecated/
Most of the changes related to
https://sass-lang.com/documentation/breaking-changes/slash-div/