Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.9] [APM] Fix broken unit tests (#161636) #161782

Merged
merged 1 commit into from
Jul 12, 2023
Merged

[8.9] [APM] Fix broken unit tests (#161636) #161782

merged 1 commit into from
Jul 12, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.9:

Questions ?

Please refer to the Backport tool documentation

@sorenlouv
[APM] Fix broken unit tests (elastic#161636)
d5943de 
A bunch of APM unit tests were passing on CI but failing locally. This
PR fixes the unit tests

**Why fail locally and pass on CI??**
The reason they pass on CI is because `console.error` calls are omitted.
In the APM jest config `console.error` is treated as a test failure:

https://github.com/elastic/kibana/blob/7ea0dd6b116a93024d68ea2d93fa4ce90e9bf189/x-pack/plugins/apm/jest_setup.js#L12-L15
(cherry picked from commit ccb36d9)
@kibanamachine kibanamachine enabled auto-merge (squash) July 12, 2023 15:24
@kibanamachine kibanamachine mentioned this pull request Jul 12, 2023
Merged
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 415 419 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 496 500 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sqren

@kibanamachine kibanamachine merged commit 5442b6b into elastic:8.9 Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@sorenlouv sorenlouv

Labels
backport Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kibanamachine @elasticmachine @kibana-ci @sorenlouv