Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs+] Add title / icons to installed packages API #161777

Merged
merged 5 commits into from
Jul 13, 2023
Merged

[Logs+] Add title / icons to installed packages API #161777

merged 5 commits into from
Jul 13, 2023

Conversation

Kerry350
Copy link
Contributor

@Kerry350 Kerry350 commented Jul 12, 2023 •
edited
Loading

Summary

Implements #160935.

This PR adds the title and icons (also description since it was there) properties to the installed packages API, these are extracted from the matching manifest assets (so that we don't have to call the registry, and can query for multiple items at once). Discover has also been updated to use these new properties.

List:

Screenshot 2023-07-12 at 17 13 52

With selection:

Screenshot 2023-07-12 at 17 14 10

I've made this robust against a matching manifest asset not being found - I don't think this is actually possible, but just incase.

Testing

  • When accessing the log explorer profile within Discover pretty titles should be displayed in the dataset selector
  • When accessing the log explorer profile within Discover icons should be displayed in the dataset selector

@Kerry350 Kerry350 added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 12, 2023
@Kerry350 Kerry350 self-assigned this Jul 12, 2023
@Kerry350 Kerry350 requested review from a team as code owners July 12, 2023 14:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@Kerry350
Copy link
Contributor Author

@elasticmachine merge upstream

Kerry350 added 2 commits July 12, 2023 16:59
@Kerry350
Switch to Map
8a3e431 
Slightly more elegant for access. Shouldn't be less performant vs multiple finds.
@Kerry350
Update Discover references
9ddca17
tonyghiani
tonyghiani approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes!

@Kerry350
Slightly alter types
37d5ae0 
Slightly changes the types so the properties are optional vs just defining undefined in the union. This
is mostly to appease fromSelection() as it tries to reconstruct from a partial integration payload.
Once the hydration function is used (it's only call location) we should probably expand the payload for
the integration properties. Also appeases storybook.

 # Please enter the commit message for your changes. Lines starting
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests #1 / Endpoint Policy Response from Fleet Agent Details page should display policy response with errors
  • [job] [logs] FTR Configs #27 / lens app - group 5 lens formula should insert single quotes and escape when needed to create valid field name

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discoverLogExplorer 192.0KB 192.5KB +467.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 409 413 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 488 492 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kerry350

juliaElastic
juliaElastic approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kerry350 Kerry350 merged commit 52c645f into elastic:main Jul 13, 2023
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

@tonyghiani tonyghiani tonyghiani approved these changes

Assignees

@Kerry350 Kerry350

Labels
backport:skip This commit does not require backporting Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Kerry350 @elasticmachine @apmmachine @kibana-ci @tonyghiani @juliaElastic @kibanamachine