Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ftr] migrate time picker GUI selection to uiSettings API call #161642

Merged
merged 9 commits into from
Jul 12, 2023
Merged

[ftr] migrate time picker GUI selection to uiSettings API call #161642

merged 9 commits into from
Jul 12, 2023

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Jul 11, 2023 •
edited by kibanamachine
Loading

closes #113998

In order to make FTR functional tests faster and less flaky, we started migrating time picker selection from UI action to Kibana API call:

    await this.kibanaServer.uiSettings.update({
      'timepicker:timeDefaults': `{ "from": <startTime>, "to": <endTime>}`,
    });

In this PR I updated most of the tests listed in the meta issue, so we can close it.

Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2606

@dmlemeshko dmlemeshko changed the title Ftr/select time via user settings [ftr] migrate time picker ui selection to user settings API call Jul 11, 2023
@dmlemeshko dmlemeshko changed the title [ftr] migrate time picker ui selection to user settings API call [ftr] migrate time picker GUI selection to uiSettings API call Jul 11, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 409 413 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 488 492 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes v8.10.0 v8.8.3 v8.9.1 labels Jul 11, 2023
@dmlemeshko dmlemeshko marked this pull request as ready for review July 11, 2023 14:59
@dmlemeshko dmlemeshko requested review from a team as code owners July 11, 2023 14:59
davismcphee
davismcphee approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery FT changes LGTM 👍

stratoula
stratoula approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vis team changes LGTM, code review only!

@dmlemeshko dmlemeshko merged commit 85a99c9 into elastic:main Jul 12, 2023
@kibanamachine kibanamachine mentioned this pull request Jul 12, 2023
Closed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 12, 2023
@dmlemeshko
[ftr] migrate time picker GUI selection to uiSettings API call (elast…
dfdcc01 
…ic#161642)

closes elastic#113998

In order to make FTR functional tests faster and less flaky, we started
migrating time picker selection from UI action to Kibana API call:

```
    await this.kibanaServer.uiSettings.update({
      'timepicker:timeDefaults': `{ "from": <startTime>, "to": <endTime>}`,
    });
```

In this PR I updated most of the tests listed in the meta issue, so we
can close it.

Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2606

(cherry picked from commit 85a99c9)
@kibanamachine kibanamachine mentioned this pull request Jul 12, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 12, 2023
@dmlemeshko
[ftr] migrate time picker GUI selection to uiSettings API call (elast…
c52eecc 
…ic#161642)

closes elastic#113998

In order to make FTR functional tests faster and less flaky, we started
migrating time picker selection from UI action to Kibana API call:

```
    await this.kibanaServer.uiSettings.update({
      'timepicker:timeDefaults': `{ "from": <startTime>, "to": <endTime>}`,
    });
```

In this PR I updated most of the tests listed in the meta issue, so we
can close it.

Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2606

(cherry picked from commit 85a99c9)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 12, 2023
@kibanamachine @dmlemeshko
[8.9] [ftr] migrate time picker GUI selection to uiSettings API call (#…
79d6593 
…161642) (#161725)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[ftr] migrate time picker GUI selection to uiSettings API call
(#161642)](#161642)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dzmitry
Lemechko","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-12T07:06:53Z","message":"[ftr]
migrate time picker GUI selection to uiSettings API call
(#161642)\n\ncloses #113998\r\n\r\nIn order to make FTR functional tests
faster and less flaky, we started\r\nmigrating time picker selection
from UI action to Kibana API call:\r\n\r\n```\r\n await
this.kibanaServer.uiSettings.update({\r\n 'timepicker:timeDefaults': `{
\"from\": <startTime>, \"to\": <endTime>}`,\r\n });\r\n```\r\n\r\nIn
this PR I updated most of the tests listed in the meta issue, so
we\r\ncan close it.\r\n\r\nFlaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2606","sha":"85a99c954f386bfa6291b266fe94a1456e312b25","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.10.0","v8.8.3","v8.9.1"],"number":161642,"url":"https://github.com/elastic/kibana/pull/161642","mergeCommit":{"message":"[ftr]
migrate time picker GUI selection to uiSettings API call
(#161642)\n\ncloses #113998\r\n\r\nIn order to make FTR functional tests
faster and less flaky, we started\r\nmigrating time picker selection
from UI action to Kibana API call:\r\n\r\n```\r\n await
this.kibanaServer.uiSettings.update({\r\n 'timepicker:timeDefaults': `{
\"from\": <startTime>, \"to\": <endTime>}`,\r\n });\r\n```\r\n\r\nIn
this PR I updated most of the tests listed in the meta issue, so
we\r\ncan close it.\r\n\r\nFlaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2606","sha":"85a99c954f386bfa6291b266fe94a1456e312b25"}},"sourceBranch":"main","suggestedTargetBranches":["8.8","8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161642","number":161642,"mergeCommit":{"message":"[ftr]
migrate time picker GUI selection to uiSettings API call
(#161642)\n\ncloses #113998\r\n\r\nIn order to make FTR functional tests
faster and less flaky, we started\r\nmigrating time picker selection
from UI action to Kibana API call:\r\n\r\n```\r\n await
this.kibanaServer.uiSettings.update({\r\n 'timepicker:timeDefaults': `{
\"from\": <startTime>, \"to\": <endTime>}`,\r\n });\r\n```\r\n\r\nIn
this PR I updated most of the tests listed in the meta issue, so
we\r\ncan close it.\r\n\r\nFlaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2606","sha":"85a99c954f386bfa6291b266fe94a1456e312b25"}},{"branch":"8.8","label":"v8.8.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dzmitry Lemechko <[email protected]>
@dmlemeshko dmlemeshko removed the v8.8.3 label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v8.9.0 v8.9.1 v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[meta] [refactor] use ui settings instead of timepicker ui
5 participants
@dmlemeshko @kibana-ci @kibanamachine @stratoula @davismcphee