Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Guided onboarding] Migrate all usages of EuiPage*_Deprecated #161457

Merged
merged 2 commits into from
Jul 10, 2023
Merged

[Guided onboarding] Migrate all usages of EuiPage*_Deprecated #161457

merged 2 commits into from
Jul 10, 2023

Conversation

claracruz
Copy link
Contributor

Summary

This PR removes all usages of EuiPage*_Deprecated for:

  • EuiPageContentBody_Deprecated -> Use EuiPageSection instead
  • EuiPageContentHeader_Deprecated -> Use EuiPageHeader instead

Fixes: #161427

@claracruz claracruz added enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Journey/Onboarding Platform Journey Onboarding team v8.10.0 labels Jul 7, 2023
@claracruz claracruz requested a review from a team as a code owner July 7, 2023 12:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 408 412 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 487 491 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

bollinic
bollinic approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@bollinic bollinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@claracruz claracruz merged commit 0e0106a into elastic:main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bollinic bollinic bollinic approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:Journey/Onboarding Platform Journey Onboarding team v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Onboarding] Migrate all usages of EuiPage*_Deprecated
5 participants
@claracruz @elasticmachine @kibana-ci @bollinic @kibanamachine