Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add TOC to landing page #161411

Merged
merged 3 commits into from
Jul 7, 2023
Merged

[DOCS] Add TOC to landing page #161411

merged 3 commits into from
Jul 7, 2023

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Jul 7, 2023

Summary

  • Adds the TOC to the Kibana docs landing page. Removes the right sidebar from the landing page.
  • Removes the "View all Elastic docs" link from the bottom of the landing page

Screenshots

Before

kibana-before

After

kibana-after

@jrodewig jrodewig added Team:Docs release_note:skip Skip the PR/issue when compiling release notes docs v8.9.0 v8.10.0 v8.8.3 labels Jul 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Documentation preview:

@jrodewig jrodewig marked this pull request as ready for review July 7, 2023 00:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@jrodewig jrodewig requested a review from a team July 7, 2023 00:58
@@ -281,4 +282,19 @@ <h4 class="mt-3">
</div>
</div>

<p class="my-4"><a href="https://www.elastic.co/guide/index.html">View all Elastic docs</a></p>
<script>
Copy link
Contributor Author

@jrodewig jrodewig Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrodewig jrodewig requested a review from amyjtechwriter July 7, 2023 12:40
Copy link
Contributor

@amyjtechwriter amyjtechwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on Chrome and Safari!

@jrodewig jrodewig merged commit b7b198e into elastic:main Jul 7, 2023
@jrodewig jrodewig deleted the add-toc-to-landing-page branch July 7, 2023 16:03
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 7, 2023
### Summary
- Adds the TOC to the Kibana docs landing page. Removes the right sidebar from the landing page.
- Removes the "View all Elastic docs" link from the bottom of the landing page

(cherry picked from commit b7b198e)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 7, 2023
### Summary
- Adds the TOC to the Kibana docs landing page. Removes the right sidebar from the landing page.
- Removes the "View all Elastic docs" link from the bottom of the landing page

(cherry picked from commit b7b198e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.8
8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 7, 2023
# Backport

This will backport the following commits from `main` to `8.9`:
- [[DOCS] Add TOC to landing page
(#161411)](#161411)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Rodewig","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-07T16:03:32Z","message":"[DOCS]
Add TOC to landing page (#161411)\n\n### Summary\r\n- Adds the TOC to
the Kibana docs landing page. Removes the right sidebar from the landing
page.\r\n- Removes the \"View all Elastic docs\" link from the bottom of
the landing
page","sha":"b7b198e2ba435df5bc909042d2a8dc0e2ab9967a","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","v8.9.0","v8.10.0","v8.8.3"],"number":161411,"url":"https://github.com/elastic/kibana/pull/161411","mergeCommit":{"message":"[DOCS]
Add TOC to landing page (#161411)\n\n### Summary\r\n- Adds the TOC to
the Kibana docs landing page. Removes the right sidebar from the landing
page.\r\n- Removes the \"View all Elastic docs\" link from the bottom of
the landing
page","sha":"b7b198e2ba435df5bc909042d2a8dc0e2ab9967a"}},"sourceBranch":"main","suggestedTargetBranches":["8.9","8.8"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161411","number":161411,"mergeCommit":{"message":"[DOCS]
Add TOC to landing page (#161411)\n\n### Summary\r\n- Adds the TOC to
the Kibana docs landing page. Removes the right sidebar from the landing
page.\r\n- Removes the \"View all Elastic docs\" link from the bottom of
the landing
page","sha":"b7b198e2ba435df5bc909042d2a8dc0e2ab9967a"}},{"branch":"8.8","label":"v8.8.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: James Rodewig <[email protected]>
kibanamachine added a commit that referenced this pull request Jul 7, 2023
# Backport

This will backport the following commits from `main` to `8.8`:
- [[DOCS] Add TOC to landing page
(#161411)](#161411)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Rodewig","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-07T16:03:32Z","message":"[DOCS]
Add TOC to landing page (#161411)\n\n### Summary\r\n- Adds the TOC to
the Kibana docs landing page. Removes the right sidebar from the landing
page.\r\n- Removes the \"View all Elastic docs\" link from the bottom of
the landing
page","sha":"b7b198e2ba435df5bc909042d2a8dc0e2ab9967a","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","v8.9.0","v8.10.0","v8.8.3"],"number":161411,"url":"https://github.com/elastic/kibana/pull/161411","mergeCommit":{"message":"[DOCS]
Add TOC to landing page (#161411)\n\n### Summary\r\n- Adds the TOC to
the Kibana docs landing page. Removes the right sidebar from the landing
page.\r\n- Removes the \"View all Elastic docs\" link from the bottom of
the landing
page","sha":"b7b198e2ba435df5bc909042d2a8dc0e2ab9967a"}},"sourceBranch":"main","suggestedTargetBranches":["8.9","8.8"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161411","number":161411,"mergeCommit":{"message":"[DOCS]
Add TOC to landing page (#161411)\n\n### Summary\r\n- Adds the TOC to
the Kibana docs landing page. Removes the right sidebar from the landing
page.\r\n- Removes the \"View all Elastic docs\" link from the bottom of
the landing
page","sha":"b7b198e2ba435df5bc909042d2a8dc0e2ab9967a"}},{"branch":"8.8","label":"v8.8.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: James Rodewig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.8.3 v8.9.0 v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants