-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Add TOC to landing page #161411
[DOCS] Add TOC to landing page #161411
Conversation
Documentation preview: |
Pinging @elastic/kibana-docs (Team:Docs) |
@@ -281,4 +282,19 @@ <h4 class="mt-3"> | |||
</div> | |||
</div> | |||
|
|||
<p class="my-4"><a href="https://www.elastic.co/guide/index.html">View all Elastic docs</a></p> | |||
<script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script was copied from the Observability docs landing page:
https://github.com/elastic/observability-docs/blob/2c5ec189bd08f43366a39796137ad5c26c139247/docs/en/observability/landing-page/temp/script.asciidoc?plain=1#L2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on Chrome and Safari!
### Summary - Adds the TOC to the Kibana docs landing page. Removes the right sidebar from the landing page. - Removes the "View all Elastic docs" link from the bottom of the landing page (cherry picked from commit b7b198e)
### Summary - Adds the TOC to the Kibana docs landing page. Removes the right sidebar from the landing page. - Removes the "View all Elastic docs" link from the bottom of the landing page (cherry picked from commit b7b198e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.9`: - [[DOCS] Add TOC to landing page (#161411)](#161411) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Rodewig","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-07T16:03:32Z","message":"[DOCS] Add TOC to landing page (#161411)\n\n### Summary\r\n- Adds the TOC to the Kibana docs landing page. Removes the right sidebar from the landing page.\r\n- Removes the \"View all Elastic docs\" link from the bottom of the landing page","sha":"b7b198e2ba435df5bc909042d2a8dc0e2ab9967a","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","v8.9.0","v8.10.0","v8.8.3"],"number":161411,"url":"https://github.com/elastic/kibana/pull/161411","mergeCommit":{"message":"[DOCS] Add TOC to landing page (#161411)\n\n### Summary\r\n- Adds the TOC to the Kibana docs landing page. Removes the right sidebar from the landing page.\r\n- Removes the \"View all Elastic docs\" link from the bottom of the landing page","sha":"b7b198e2ba435df5bc909042d2a8dc0e2ab9967a"}},"sourceBranch":"main","suggestedTargetBranches":["8.9","8.8"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161411","number":161411,"mergeCommit":{"message":"[DOCS] Add TOC to landing page (#161411)\n\n### Summary\r\n- Adds the TOC to the Kibana docs landing page. Removes the right sidebar from the landing page.\r\n- Removes the \"View all Elastic docs\" link from the bottom of the landing page","sha":"b7b198e2ba435df5bc909042d2a8dc0e2ab9967a"}},{"branch":"8.8","label":"v8.8.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Rodewig <[email protected]>
# Backport This will backport the following commits from `main` to `8.8`: - [[DOCS] Add TOC to landing page (#161411)](#161411) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Rodewig","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-07T16:03:32Z","message":"[DOCS] Add TOC to landing page (#161411)\n\n### Summary\r\n- Adds the TOC to the Kibana docs landing page. Removes the right sidebar from the landing page.\r\n- Removes the \"View all Elastic docs\" link from the bottom of the landing page","sha":"b7b198e2ba435df5bc909042d2a8dc0e2ab9967a","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","v8.9.0","v8.10.0","v8.8.3"],"number":161411,"url":"https://github.com/elastic/kibana/pull/161411","mergeCommit":{"message":"[DOCS] Add TOC to landing page (#161411)\n\n### Summary\r\n- Adds the TOC to the Kibana docs landing page. Removes the right sidebar from the landing page.\r\n- Removes the \"View all Elastic docs\" link from the bottom of the landing page","sha":"b7b198e2ba435df5bc909042d2a8dc0e2ab9967a"}},"sourceBranch":"main","suggestedTargetBranches":["8.9","8.8"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161411","number":161411,"mergeCommit":{"message":"[DOCS] Add TOC to landing page (#161411)\n\n### Summary\r\n- Adds the TOC to the Kibana docs landing page. Removes the right sidebar from the landing page.\r\n- Removes the \"View all Elastic docs\" link from the bottom of the landing page","sha":"b7b198e2ba435df5bc909042d2a8dc0e2ab9967a"}},{"branch":"8.8","label":"v8.8.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Rodewig <[email protected]>
Summary
Screenshots
Before
After