[dashboard] fix Memory leak when reset causes by-value panel to be deleted #161394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:skip
…-ref HEAD~1..HEAD --fix'
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
LGTM! though this may conflict with #159837 because the embeddable panel file has been totally re-structured in that PR. (and has the early return!)
That said, it's worth it to merge this, because I won't be backporting that PR!
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 7, 2023
…leted (elastic#161394) Closes elastic#161310 Issue caused by `setState` call after async action without checking that component is still mounted. Resolved issue by checking component is mounted after any async action or subscription. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit d9c0c55)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 7, 2023
… be deleted (#161394) (#161467) # Backport This will backport the following commits from `main` to `8.9`: - [[dashboard] fix Memory leak when reset causes by-value panel to be deleted (#161394)](#161394) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-07T14:53:50Z","message":"[dashboard] fix Memory leak when reset causes by-value panel to be deleted (#161394)\n\nCloses https://github.com/elastic/kibana/issues/161310\r\n\r\nIssue caused by `setState` call after async action without checking that\r\ncomponent is still mounted. Resolved issue by checking component is\r\nmounted after any async action or subscription.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"d9c0c554f8e54068c5fd8d0c27094f0d04c6dac3","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding","Team:Presentation","release_note:skip","v8.9.0","v8.10.0","Feature:Embeddables"],"number":161394,"url":"https://github.com/elastic/kibana/pull/161394","mergeCommit":{"message":"[dashboard] fix Memory leak when reset causes by-value panel to be deleted (#161394)\n\nCloses https://github.com/elastic/kibana/issues/161310\r\n\r\nIssue caused by `setState` call after async action without checking that\r\ncomponent is still mounted. Resolved issue by checking component is\r\nmounted after any async action or subscription.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"d9c0c554f8e54068c5fd8d0c27094f0d04c6dac3"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161394","number":161394,"mergeCommit":{"message":"[dashboard] fix Memory leak when reset causes by-value panel to be deleted (#161394)\n\nCloses https://github.com/elastic/kibana/issues/161310\r\n\r\nIssue caused by `setState` call after async action without checking that\r\ncomponent is still mounted. Resolved issue by checking component is\r\nmounted after any async action or subscription.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"d9c0c554f8e54068c5fd8d0c27094f0d04c6dac3"}}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #161310
Issue caused by
setStatecall after async action without checking that component is still mounted. Resolved issue by checking component is mounted after any async action or subscription.