-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Actions] System actions authorization #161341
Merged
Merged
Changes from 48 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
1352e52
Add isSystemAction to ActionResult type and default it to false
cnasikas 09b82f6
Disallow registering system actions
cnasikas dc1a2c8
Add test
cnasikas bb7e9a5
Fix alerting types
cnasikas 774b389
Fix integration tests
cnasikas 83ee747
Fix triggers_actions_ui types
cnasikas d2b8e67
Fix cases types
cnasikas 31f1f39
Fix cases tests
cnasikas 85ca6a4
Fix integration tests
cnasikas b070bd9
Fix cases tests
cnasikas a8e7143
Merge branch 'main' into system_actions_registration
kibanamachine b50a3e0
Fix types from other plugins
cnasikas ee5df7b
Merge branch 'system_actions_registration' of github.com:cnasikas/kib…
cnasikas 1caf874
Rename preconfiguredConnectors to inMemoryConnectors
cnasikas 2aabeed
Create system actions
cnasikas 3cf469a
Prevent create/update/delete of system actions
cnasikas 8c1246c
Fix types
cnasikas 0d7aea1
Merge branch 'main' into load_system_actions_in_memory
cnasikas 52ef0e5
Fix types
cnasikas d763161
Remove cases from basic
cnasikas 5c3245e
Convert preconfigured to in-memory
cnasikas 31bc750
Merge branch 'main' into load_system_actions_in_memory
cnasikas d35a7f9
Get in-memory connectors after they have been created in the route co…
cnasikas 34ee2ab
Register test system action in integration tests
cnasikas 86b279c
Add integration tests
cnasikas 57b4d3a
Fix i18n
cnasikas a162163
Fix types
cnasikas 2ea3c9c
Fix integration test
cnasikas 7362b97
Fixes
cnasikas cbaeb1f
Merge branch 'main' into load_system_actions_in_memory
cnasikas a1b5d51
Filtered out system connectors in telemetry
cnasikas 45c4690
Add the ability to pass additional privileges to the actions authoriz…
cnasikas 2db46a0
Perform system actions RBAC
cnasikas 9ebb327
Fix types and tests
cnasikas 45f0265
Add unit tests
cnasikas e62faae
Add integration tests
cnasikas 15da2b9
Add integration tests
cnasikas 17d3c6e
Merge branch 'main' into system_actions_rbac
cnasikas 637a6b3
Merge branch 'main' into system_actions_rbac
cnasikas eca005d
Fix tests
cnasikas 0020ee9
Enhancements
cnasikas 356432c
Pass params to system actions when getting kibana privileges
cnasikas 4259f54
Fix integration tests
cnasikas c44f49d
Add integration tests for enqueue
cnasikas 4035d11
Add integration tests for bulk_enqueue
cnasikas be7ec67
Add integration tests for spaces_only
cnasikas 2c565b1
Fix integration tests
cnasikas a9e3bd5
Merge branch 'main' into system_actions_rbac
cnasikas 72e9d72
Small improvements
cnasikas a8ea16b
Merge branch 'main' into system_actions_rbac
cnasikas dddcc8e
Do not allow setting kibana privileges if it is not a system action type
cnasikas 8a9e449
Fix test
cnasikas 1794087
Fix i18n
cnasikas 0a07366
Merge branch 'main' into system_actions_rbac
cnasikas 59cfda7
PR feedback
cnasikas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://github.com/elastic/kibana/pull/161341/files#r1257471094