-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ftr] fix test users for serverless #161280
Conversation
@@ -200,7 +201,7 @@ export const schema = Joi.object() | |||
.keys({ | |||
license: Joi.valid('basic', 'trial', 'gold').default('basic'), | |||
from: Joi.string().default('snapshot'), | |||
serverArgs: Joi.array().items(Joi.string()), | |||
serverArgs: Joi.array().items(Joi.string()).default([]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will help us to clean code a bit and avoid config.get('esTestCluster.serverArgs') || []
in many places
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ops changes lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Tested all six configurations locally and against serverless QA projects.
Summary
This PR fixes few issues occurring while running FTR API tests against actual serverless project.
How to run:
The first error is faced during Elasticsearch version validation
Since there is no version term in case of serverless, we can skip version check by using newly added to FTR schema
serverless
property (false
by default). It is set totrue
in root FTR config/shared/config.base
.The next error is related to ESArchiver relying on
ES
FTR service to provide ESClient.It is fixed by using the default user (from host url) instead of
system_indices_superuser
we use in stateful run.