Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Removing passing of error object to logger.error as meta parameter #161276

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jul 5, 2023

Summary

Removing passing of error object to logger.error as meta parameter !!

@shahzad31 shahzad31 requested a review from a team as a code owner July 5, 2023 15:56
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jul 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.9.0 v8.10.0 labels Jul 5, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 489 493 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shahzad31 shahzad31 merged commit 6b52658 into elastic:main Jul 7, 2023
@shahzad31 shahzad31 deleted the fix-error-log branch July 7, 2023 09:55
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 7, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 7, 2023
…s meta parameter (#161276) (#161439)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Synthetics] Removing passing of error object to logger.error as meta
parameter (#161276)](#161276)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-07T09:53:27Z","message":"[Synthetics]
Removing passing of error object to logger.error as meta parameter
(#161276)","sha":"6b52658af7186266bb5507d997d67d3d3c423cee","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:uptime","release_note:skip","v8.9.0","v8.10.0"],"number":161276,"url":"https://github.com/elastic/kibana/pull/161276","mergeCommit":{"message":"[Synthetics]
Removing passing of error object to logger.error as meta parameter
(#161276)","sha":"6b52658af7186266bb5507d997d67d3d3c423cee"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161276","number":161276,"mergeCommit":{"message":"[Synthetics]
Removing passing of error object to logger.error as meta parameter
(#161276)","sha":"6b52658af7186266bb5507d997d67d3d3c423cee"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.9.0 v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants