Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Exceptions] Amend Rule Exception's Comment text #161092

Merged
merged 6 commits into from
Jul 5, 2023
Merged

[Security Solution] [Exceptions] Amend Rule Exception's Comment text #161092

merged 6 commits into from
Jul 5, 2023

Conversation

WafaaNasr
Copy link
Contributor

@WafaaNasr WafaaNasr commented Jul 3, 2023 •
edited by kibanamachine
Loading

@WafaaNasr WafaaNasr added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.9.0 Team:Detection Engine Security Solution Detection Engine Area labels Jul 3, 2023
@WafaaNasr WafaaNasr requested a review from a team as a code owner July 3, 2023 13:12
@WafaaNasr WafaaNasr self-assigned this Jul 3, 2023
nastasha-solomon
nastasha-solomon approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, @WafaaNasr :)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.0MB 11.0MB +18.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 489 493 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @WafaaNasr

@WafaaNasr WafaaNasr merged commit 16528cf into elastic:main Jul 5, 2023
@kibanamachine kibanamachine mentioned this pull request Jul 5, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 5, 2023
@WafaaNasr
[Security Solution] [Exceptions] Amend Rule Exception's Comment text (
cdbd19b 
elastic#161092)

## Summary

- Addresses Docs team comment
elastic#159908 (comment)

(cherry picked from commit 16528cf)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 5, 2023
@kibanamachine @WafaaNasr
[8.9] [Security Solution] [Exceptions] Amend `Rule Exception's Commen…
72db88f 
…t` text (#161092) (#161242)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Security Solution] [Exceptions] Amend `Rule Exception's Comment`
text (#161092)](#161092)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Wafaa
Nasr","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-07-05T10:44:03Z","message":"[Security
Solution] [Exceptions] Amend `Rule Exception's Comment` text
(#161092)\n\n## Summary\r\n\r\n- Addresses Docs team
comment\r\nhttps://github.com//pull/159908#discussion_r1247964658","sha":"16528cf28994b30642262a018c89c5217c28f884","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","v8.9.0","Team:Detection
Engine","v8.10.0"],"number":161092,"url":"https://github.com/elastic/kibana/pull/161092","mergeCommit":{"message":"[Security
Solution] [Exceptions] Amend `Rule Exception's Comment` text
(#161092)\n\n## Summary\r\n\r\n- Addresses Docs team
comment\r\nhttps://github.com//pull/159908#discussion_r1247964658","sha":"16528cf28994b30642262a018c89c5217c28f884"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161092","number":161092,"mergeCommit":{"message":"[Security
Solution] [Exceptions] Amend `Rule Exception's Comment` text
(#161092)\n\n## Summary\r\n\r\n- Addresses Docs team
comment\r\nhttps://github.com//pull/159908#discussion_r1247964658","sha":"16528cf28994b30642262a018c89c5217c28f884"}}]}]
BACKPORT-->

Co-authored-by: Wafaa Nasr <[email protected]>
@WafaaNasr WafaaNasr deleted the fix-exception-autopopulate-comment branch February 6, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastasha-solomon nastasha-solomon nastasha-solomon approved these changes

@yctercero yctercero yctercero approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area v8.9.0 v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WafaaNasr @kibana-ci @kibanamachine @yctercero @nastasha-solomon