Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deployment Management] Add landing page redirect feature and implement in security solution #161060

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Jul 3, 2023

Fixes #161000

Summary

The serverless-security solution will have their own management landing page that lives in a different URL as the management pages for oblt and search. To streamline access to all management pages through a single URL, we have implemented an API that allows the security solution to specify a different URL for redirection when required. This ensures a seamless user experience while navigating between various management interfaces.

As a placeholder for now I've set the redirect for the security landing page to:

management.setLandingPageRedirect('/app/security/manage');
How to test
  • Boot up the security solution and make sure that going to http://localhost:5601/ekv/app/management will redirect you to http://localhost:5601/ekv/app/security/manage.
  • Boot up any other solution and make sure that http://localhost:5601/ekv/app/management takes you to the managements default landing page.

@sabarasaba sabarasaba added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Project:Serverless Work as part of the Serverless project for its initial release v8.10.0 labels Jul 3, 2023
@sabarasaba sabarasaba self-assigned this Jul 3, 2023
@sabarasaba sabarasaba marked this pull request as ready for review July 3, 2023 08:19
@sabarasaba sabarasaba requested review from a team as code owners July 3, 2023 08:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @sabarasaba! Tested the endpoints locally in all serverless projects and the redirect feature works as expected. Code changes also look good to me! 🎉

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
management 45 47 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
management 42.3KB 42.6KB +248.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
management 10.3KB 10.4KB +167.0B
serverlessSecurity 20.4KB 20.5KB +62.0B
total +229.0B
Unknown metric groups

API count

id before after diff
management 45 47 +2

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 489 493 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@sabarasaba sabarasaba merged commit 2a71469 into elastic:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Management] Create api that allows users to configure a redirect instead of using our own landing page
6 participants