[data views] Fix overwrite param for create

src/plugins/data_views/common/content_management/v1/cm_services.ts

@@ -54,6 +54,7 @@ const dataViewSavedObjectSchema = savedObjectSchema(dataViewAttributesSchema);
 const dataViewCreateOptionsSchema = schema.object({
   id: createOptionsSchemas.id,
   initialNamespaces: createOptionsSchemas.initialNamespaces,
+  overwrite: schema.maybe(createOptionsSchemas.overwrite),
 });
 
 const dataViewSearchOptionsSchema = schema.object({

src/plugins/data_views/common/content_management/v1/types.ts

@@ -18,6 +18,7 @@ import { DataViewContentType } from './constants';
 interface DataViewCreateOptions {
   id?: SavedObjectCreateOptions['id'];
   initialNamespaces?: SavedObjectCreateOptions['initialNamespaces'];
+  overwrite?: SavedObjectCreateOptions['overwrite'];
 }
 
 interface DataViewUpdateOptions {

src/plugins/data_views/common/data_views/data_views.ts

@@ -167,7 +167,7 @@ export interface DataViewsServicePublicMethods {
    */
   createSavedObject: (
     indexPattern: DataView,
-    override?: boolean,
+    overwrite?: boolean,
     displayErrors?: boolean
   ) => Promise<DataView>;
   /**
@@ -964,12 +964,16 @@ export class DataViewsService {
 
   async createAndSave(
     spec: DataViewSpec,
-    override = false,
+    overwrite = false,
     skipFetchFields = false,
     displayErrors = true
   ) {
     const indexPattern = await this.createFromSpec(spec, skipFetchFields, displayErrors);
-    const createdIndexPattern = await this.createSavedObject(indexPattern, override, displayErrors);
+    const createdIndexPattern = await this.createSavedObject(
+      indexPattern,
+      overwrite,
+      displayErrors
+    );
     await this.setDefault(createdIndexPattern.id!);
     return createdIndexPattern!;
   }
@@ -981,14 +985,14 @@ export class DataViewsService {
    * @param displayErrors - If set false, API consumer is responsible for displaying and handling errors.
    */
 
-  async createSavedObject(dataView: DataView, override = false, displayErrors = true) {
+  async createSavedObject(dataView: DataView, overwrite = false, displayErrors = true) {
     if (!(await this.getCanSave())) {
       throw new DataViewInsufficientAccessError();
     }
     const dupe = await findByName(this.savedObjectsClient, dataView.getName());
 
     if (dupe) {
-      if (override) {
+      if (overwrite) {
         await this.delete(dupe.id);
       } else {
         throw new DuplicateDataViewError(`Duplicate data view: ${dataView.getName()}`);
@@ -1000,6 +1004,7 @@ export class DataViewsService {
     const response: SavedObject<DataViewAttributes> = (await this.savedObjectsClient.create(body, {
       id: dataView.id,
       initialNamespaces: dataView.namespaces.length > 0 ? dataView.namespaces : undefined,
+      overwrite,
     })) as SavedObject<DataViewAttributes>;
 
     const createdIndexPattern = await this.initFromSavedObject(response, displayErrors);

src/plugins/data_views/common/types.ts

@@ -297,7 +297,7 @@ export interface SavedObjectsClientCommon {
   create: (
     attributes: DataViewAttributes,
     // SavedObjectsCreateOptions
-    options: { id?: string; initialNamespaces?: string[] }
+    options: { id?: string; initialNamespaces?: string[]; overwrite?: boolean }
   ) => Promise<SavedObject>;
   /**
    * Delete a saved object by id

test/api_integration/apis/data_views/fields_api/update_fields/main.ts

@@ -437,6 +437,7 @@ export default function ({ getService }: FtrProviderContext) {
             const title = indexPattern.title;
             await supertest.delete(`${config.path}/${indexPattern.id}`);
             const response1 = await supertest.post(config.path).send({
+              override: true,
               [config.serviceKey]: {
                 title,
                 fields: {