Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Endpoint] Reduce fleet artifact calls #160890

Merged
merged 6 commits into from
Jun 30, 2023
Merged

[Security Solution][Endpoint] Reduce fleet artifact calls #160890

merged 6 commits into from
Jun 30, 2023

Conversation

dasansol92
Copy link
Contributor

@dasansol92 dasansol92 commented Jun 29, 2023 •
edited
Loading

Summary

  • Reduces fleet artifact get calls by getting them all at one time instead of requesting it one by one using id's
  • Updates unit test.
  • Adds duration time log to endpoint packager task.
  • Adds missing return types to functions.

Follow up of: #160387

@dasansol92 dasansol92 added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.10.0 labels Jun 29, 2023
@dasansol92 dasansol92 marked this pull request as ready for review June 29, 2023 13:47
@dasansol92 dasansol92 requested a review from a team as a code owner June 29, 2023 13:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

ashokaditya
ashokaditya approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick changes. 🚢 it!!

x-pack/plugins/security_solution/server/endpoint/lib/artifacts/task.ts Outdated
@@ -53,7 +53,12 @@ export class ManifestTask {
return {
run: async () => {
const taskInterval = (await this.endpointAppContext.config()).packagerTaskInterval;
const initTime = new Date().getTime();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: startTime

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

339d971

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 413 417 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 492 496 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gergoabraham
gergoabraham approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dasansol92 dasansol92 merged commit 5666b14 into elastic:main Jun 30, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 30, 2023
paul-tavares
paul-tavares reviewed Jun 30, 2023
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Looks good. Thanks for all the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-tavares paul-tavares paul-tavares left review comments

@gergoabraham gergoabraham gergoabraham approved these changes

@joeypoon joeypoon joeypoon approved these changes

@ashokaditya ashokaditya ashokaditya approved these changes

@tomsonpl tomsonpl Awaiting requested review from tomsonpl tomsonpl was automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dasansol92 @elasticmachine @kibana-ci @ashokaditya @joeypoon @gergoabraham @paul-tavares @kibanamachine