[Fleet] Fixes wrong artifact Id on bulkCreate response #160710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasansol92
added
release_note:skip
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
dasansol92
requested review from
a team,
pzl and
ashokaditya
and removed request for
a team
juliaElastic
approved these changes
Jun 28, 2023
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
tomsonpl
reviewed
Jun 28, 2023
| @@ -186,13 +186,25 @@ describe('When using the artifacts services', () => { | |||
| }); | |||
|
|
|||
| it('should create and return a multiple big artifacts', async () => { | |||
| const { ...generatedArtifact1 } = generateArtifactMock({ encodedSize: 5_000_500 }); | |||
| const { ...generatedArtifact1 } = generateArtifactMock({ | |||
There was a problem hiding this comment.
why do you need to spread rest like this?
Suggested change
| const { ...generatedArtifact1 } = generateArtifactMock({ | |
| const generatedArtifact1 = generateArtifactMock({ |
There was a problem hiding this comment.
Good point, this code was already there, but what you pointed out makes totally sense
| const { ...generatedArtifact1 } = generateArtifactMock({ | ||
| encodedSize: 5_000_500, | ||
| decodedSha256: '1234', | ||
| }); | ||
| const newBigArtifact1 = generatedArtifact1; |
There was a problem hiding this comment.
sorry for the rookie question, but what is the reason to save the reference to a new const?
There was a problem hiding this comment.
Also changed in the commit above, it has done on this way before, I guess because it was taking more props
ashokaditya
approved these changes
Jun 28, 2023
|
From a conversation above with @gergoabraham, the non sorted array of artifacts for the response has been moved out of the logic that generates the artifact batches. Commit: 5e455b9 cc: @ashokaditya @juliaElastic in case you want to review again, the logic has changed but the input/output is still the same. Thanks @gergoabraham for pointing this out!! Update: Remove the empty array initialization: 1688315 |
gergoabraham
approved these changes
Jun 28, 2023
tomsonpl
approved these changes
Jun 28, 2023
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
pzl
approved these changes
Jun 28, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 28, 2023
## Summary The artifact Id on the bulkCreateArtifact response was wrong. There is no issue currently as this id is not used, but it could end up in a bug if at some point someone somewhere uses this wrong id. Improved unit test to handle this. Related PR: elastic#159187 (cherry picked from commit 4cc04bd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 28, 2023
#160752) # Backport This will backport the following commits from `main` to `8.9`: - [[Fleet] Fixes wrong artifact Id on bulkCreate response (#160710)](#160710) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"David Sánchez","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-28T13:49:31Z","message":"[Fleet] Fixes wrong artifact Id on bulkCreate response (#160710)\n\n## Summary\r\n\r\nThe artifact Id on the bulkCreateArtifact response was wrong. There is\r\nno issue currently as this id is not used, but it could end up in a bug\r\nif at some point someone somewhere uses this wrong id.\r\n\r\nImproved unit test to handle this.\r\n\r\nRelated PR: https://github.com/elastic/kibana/pull/159187","sha":"4cc04bd8e35320603a592de619791f26ce3b74a8","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","Team:Defend Workflows","v8.9.0","v8.10.0"],"number":160710,"url":"https://github.com/elastic/kibana/pull/160710","mergeCommit":{"message":"[Fleet] Fixes wrong artifact Id on bulkCreate response (#160710)\n\n## Summary\r\n\r\nThe artifact Id on the bulkCreateArtifact response was wrong. There is\r\nno issue currently as this id is not used, but it could end up in a bug\r\nif at some point someone somewhere uses this wrong id.\r\n\r\nImproved unit test to handle this.\r\n\r\nRelated PR: https://github.com/elastic/kibana/pull/159187","sha":"4cc04bd8e35320603a592de619791f26ce3b74a8"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160710","number":160710,"mergeCommit":{"message":"[Fleet] Fixes wrong artifact Id on bulkCreate response (#160710)\n\n## Summary\r\n\r\nThe artifact Id on the bulkCreateArtifact response was wrong. There is\r\nno issue currently as this id is not used, but it could end up in a bug\r\nif at some point someone somewhere uses this wrong id.\r\n\r\nImproved unit test to handle this.\r\n\r\nRelated PR: https://github.com/elastic/kibana/pull/159187","sha":"4cc04bd8e35320603a592de619791f26ce3b74a8"}}]}] BACKPORT--> Co-authored-by: David Sánchez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The artifact Id on the bulkCreateArtifact response was wrong. There is no issue currently as this id is not used, but it could end up in a bug if at some point someone somewhere uses this wrong id.
Improved unit test to handle this.
Related PR: #159187