Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Filter Cases API guardrails #160705

Merged
merged 6 commits into from
Jun 30, 2023

Conversation

adcoelho
Copy link
Contributor

@adcoelho adcoelho commented Jun 28, 2023

Connected to #146945

Summary

Description Limit Done? Documented?
Maximum number of assignees to filter 100 Yes
Maximum number of tags to filter 100 Yes
Maximum number of reporters to filter 100 Yes
  • Used schema validation.
  • Updated documentation.
  • Added jest and e2e tests.

Checklist

Delete any items that are not applicable to this PR.

Release notes

The Find Cases API now limits the array fields tags, assignees, and categories to 100 items.

Sorry, something went wrong.

Updated documentation.
Tests
@adcoelho adcoelho added release_note:breaking Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.10.0 labels Jun 28, 2023
@adcoelho adcoelho requested a review from a team as a code owner June 28, 2023 09:09
@adcoelho adcoelho self-assigned this Jun 28, 2023
@adcoelho adcoelho requested a review from a team as a code owner June 28, 2023 09:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

MAX_REPORTERS_FILTER_LENGTH,
MAX_TAGS_FILTER_LENGTH,
} from '../../constants';
import { limitedArraySchema } from '../../schema';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR but I think we should put our io-ts validation functions/helpers in a different folder. Given all the conversation around schemas, types, versioned APIs, etc the name of the folder is confusing hahaha.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OAS changes LGTM, thanks!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 421.0KB 421.0KB +2.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 143.1KB 143.3KB +176.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 413 417 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 492 496 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @adcoelho

@adcoelho adcoelho merged commit 4fb883a into elastic:main Jun 30, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:breaking Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants