Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix Transform flaky DefinePivotForm tests #160659

Merged
merged 4 commits into from
Jun 29, 2023

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Jun 27, 2023

Summary

Re-enable DefinePivotForm test by increasing the default timeout limit.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@qn895
Copy link
Member Author

qn895 commented Jun 28, 2023

@elasticmachine merge upstream

@qn895 qn895 self-assigned this Jun 28, 2023
@qn895 qn895 added :ml release_note:skip Skip the PR/issue when compiling release notes v8.9.0 v8.10.0 labels Jun 28, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 413 417 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 492 496 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@qn895 qn895 marked this pull request as ready for review June 29, 2023 14:31
@qn895 qn895 requested a review from a team as a code owner June 29, 2023 14:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@qn895 qn895 merged commit 72d30c8 into elastic:main Jun 29, 2023
@qn895 qn895 deleted the ml-fix-flaky-jest-definepivotform branch June 29, 2023 20:15
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 29, 2023
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 72d30c8)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 29, 2023
# Backport

This will backport the following commits from `main` to `8.9`:
- [[ML] Fix Transform flaky DefinePivotForm tests
(#160659)](#160659)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Quynh Nguyen
(Quinn)","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-29T20:15:04Z","message":"[ML]
Fix Transform flaky DefinePivotForm tests (#160659)\n\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"72d30c8ee26baef1b0cfb0c7f104801b67da9a0e","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v8.9.0","v8.10.0"],"number":160659,"url":"https://github.com/elastic/kibana/pull/160659","mergeCommit":{"message":"[ML]
Fix Transform flaky DefinePivotForm tests (#160659)\n\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"72d30c8ee26baef1b0cfb0c7f104801b67da9a0e"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160659","number":160659,"mergeCommit":{"message":"[ML]
Fix Transform flaky DefinePivotForm tests (#160659)\n\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"72d30c8ee26baef1b0cfb0c7f104801b67da9a0e"}}]}]
BACKPORT-->

Co-authored-by: Quynh Nguyen (Quinn) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml release_note:skip Skip the PR/issue when compiling release notes v8.9.0 v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants