Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Debt] Clean up /config and /components folders #160538

Merged
merged 7 commits into from
Jun 27, 2023

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented Jun 26, 2023

Resolves #160556

Summary

Changes:

  • Moves /components/core_web_vitals to the Overview components folder where it is used
  • Moves translations in /config/translations.ts inline
  • Moves /config/observabilityAlertFeatureIds to /observability/common/constants

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer changed the title [Tech Debt] Move Core Web Vitals to Overview page [Tech Debt] Clean up /public/config folder Jun 26, 2023
@CoenWarmer CoenWarmer changed the title [Tech Debt] Clean up /public/config folder [Tech Debt] Clean up /public/config and Jun 26, 2023
@CoenWarmer CoenWarmer changed the title [Tech Debt] Clean up /public/config and [Tech Debt] Clean up /public/config and /components folders Jun 26, 2023
@CoenWarmer CoenWarmer changed the title [Tech Debt] Clean up /public/config and /components folders [Tech Debt] Clean up /config and /components folders Jun 26, 2023
@CoenWarmer CoenWarmer marked this pull request as ready for review June 26, 2023 17:14
@CoenWarmer CoenWarmer requested a review from a team as a code owner June 26, 2023 17:14
@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label Jun 26, 2023
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@CoenWarmer CoenWarmer enabled auto-merge (squash) June 27, 2023 13:33
@CoenWarmer CoenWarmer merged commit ae7c75d into elastic:main Jun 27, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #42 / Synthetics API Tests PrivateLocationAddMonitor handles auto upgrading policies

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 423 421 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.0MB 1.0MB -5.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 71.4KB 71.6KB +123.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 413 417 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 492 496 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up /config and /components folders
5 participants