[Infrastructure UI] Metrics Explorer Saved View flaky test fix #160504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
crespocarlos
added
Feature:Metrics UI
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 27, 2023
…ic#160504) closes [elastic#156513](elastic#156513) ## Summary Fix flaky Metrics Explorer Saved Views functional test. Based on the [screenshot](https://buildkiteartifacts.com/e0f3970e-3a75-4621-919f-e6c773e2bb12/b1106efc-ba5e-4e90-a857-11c4a899c05d/0188e3a3-7b0a-4a2b-b305-41f088a36c7b/0188e3a5-5e7d-4cac-9ca2-ad049aa86341/x-pack/test/functional/screenshots/failure/InfraOps%20App%20Metrics%20UI%20Metrics%20Explorer%20Saved%20Views%20should%20update%20the%20current%20s-548c19241effa693af1bdaa2945c1bb8f7a0de0759993758d705b60a14e17c8d.png?response-content-type=image%2Fpng&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=ASIAQPCP3C7LZDIHP4OQ%2F20230626%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20230626T100738Z&X-Amz-Expires=600&X-Amz-Security-Token=IQoJb3JpZ2luX2VjENf%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLWVhc3QtMSJHMEUCIQCWRh%2Bz%2BuUkCNazAWmBVuDmsKyUAOlJ%2F71ynwSjXcFzGwIgBwzs5UgxrUrkki2Bl7ucYrIa0ldQYroVGWCAyxTTGLMq8QMIQBAAGgwwMzIzNzk3MDUzMDMiDMeqhNGm7I4CeupKPyrOA4mOkzowrCIJ9q06o%2B0LNAadRLnRcoUyBFNpVdOOZ0Mz8PCIQv8PxnVFC9c9b0o7zzxXhhIssuWjMG4bjR9PVgAL1xIMwVp9qmsfGELZ4Ctc5Py18PZ6Nsp0IYU9dj58bxyronawXCypdqG%2BaAfcETMYhr7IwusqJQKtJr0XvuWHAABjQp8KLfzU04sKG5XjZtaj%2F9i8ma2ubesispDhEjdsZYr9cy5dLqkHHEBfIi0WHc6wsdlrFge5LVQSe0Cppf7FhKubL39v2FcbPA58ftR075YDIFfgTh4jMaC502WmUBDEI1HhBNPBtGKJQz7gN6iYIlIfW8q1rXPW5KiLU3D%2ByjU0gWAO6xyBb8ShIwxJ8fCRFrpT4487g5VFrJCDwAmhuCpKWu4GtgsWvMr0VNB4M%2BKJKR7%2FicDIEjo6HIDJen1%2FvEwAWRQQOumf5Fpqt3tYYaEtf5BcnFM2EU1q5KQvcaBLvNeXiOBD8qYqfkiDlOc8Zl8C%2F%2FVd%2Fs6LusnDjzrCR%2BiM504i0p6dcjdpIsWQ9HSZKtqAGzJ9%2B34vND8hha%2BXOcuGHTY6TSflpToAv60114tLLfCekIgGhf4397Cgun2HpEB3oHO2hQRuHjDX7%2BSkBjqlAbuJIlwQmjnxEgUXwKpASBJ7B8zgesS8cANKA4i%2FO7g0to4%2FUAhICFkVy1G%2BNLUUrVX2PAMYTAH7iMU8lWxfUcIBMmg%2BCWbL4O4CKUydbwfgojalAN8KksHf%2F3IAHJkH9OrQqG3jQxGlVDUv%2B%2B1WLYwECWczrombRpDVxBl4oX3%2Baq6pvEJdERYNgMU8zfEoOXkV8kfFx7R3utq5vt9lcnB2VDR32w%3D%3D&X-Amz-SignedHeaders=host&X-Amz-Signature=f8c04b64d57c9b317c4ccb68a7961d6aa166a61b38c52b457caf5a2f87b72dfb), I suspect that the test tries to click the saved object button when it's still disabled. Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 3d05f74)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 27, 2023
…160504) (#160588) # Backport This will backport the following commits from `main` to `8.9`: - [[Infrastructure UI] Metrics Explorer Saved View flaky test fix (#160504)](#160504) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-27T07:54:20Z","message":"[Infrastructure UI] Metrics Explorer Saved View flaky test fix (#160504)\n\ncloses [#156513](https://github.com/elastic/kibana/issues/156513)\r\n\r\n## Summary\r\n\r\nFix flaky Metrics Explorer Saved Views functional test. Based on the\r\n[screenshot](https://buildkiteartifacts.com/e0f3970e-3a75-4621-919f-e6c773e2bb12/b1106efc-ba5e-4e90-a857-11c4a899c05d/0188e3a3-7b0a-4a2b-b305-41f088a36c7b/0188e3a5-5e7d-4cac-9ca2-ad049aa86341/x-pack/test/functional/screenshots/failure/InfraOps%20App%20Metrics%20UI%20Metrics%20Explorer%20Saved%20Views%20should%20update%20the%20current%20s-548c19241effa693af1bdaa2945c1bb8f7a0de0759993758d705b60a14e17c8d.png?response-content-type=image%2Fpng&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=ASIAQPCP3C7LZDIHP4OQ%2F20230626%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20230626T100738Z&X-Amz-Expires=600&X-Amz-Security-Token=IQoJb3JpZ2luX2VjENf%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLWVhc3QtMSJHMEUCIQCWRh%2Bz%2BuUkCNazAWmBVuDmsKyUAOlJ%2F71ynwSjXcFzGwIgBwzs5UgxrUrkki2Bl7ucYrIa0ldQYroVGWCAyxTTGLMq8QMIQBAAGgwwMzIzNzk3MDUzMDMiDMeqhNGm7I4CeupKPyrOA4mOkzowrCIJ9q06o%2B0LNAadRLnRcoUyBFNpVdOOZ0Mz8PCIQv8PxnVFC9c9b0o7zzxXhhIssuWjMG4bjR9PVgAL1xIMwVp9qmsfGELZ4Ctc5Py18PZ6Nsp0IYU9dj58bxyronawXCypdqG%2BaAfcETMYhr7IwusqJQKtJr0XvuWHAABjQp8KLfzU04sKG5XjZtaj%2F9i8ma2ubesispDhEjdsZYr9cy5dLqkHHEBfIi0WHc6wsdlrFge5LVQSe0Cppf7FhKubL39v2FcbPA58ftR075YDIFfgTh4jMaC502WmUBDEI1HhBNPBtGKJQz7gN6iYIlIfW8q1rXPW5KiLU3D%2ByjU0gWAO6xyBb8ShIwxJ8fCRFrpT4487g5VFrJCDwAmhuCpKWu4GtgsWvMr0VNB4M%2BKJKR7%2FicDIEjo6HIDJen1%2FvEwAWRQQOumf5Fpqt3tYYaEtf5BcnFM2EU1q5KQvcaBLvNeXiOBD8qYqfkiDlOc8Zl8C%2F%2FVd%2Fs6LusnDjzrCR%2BiM504i0p6dcjdpIsWQ9HSZKtqAGzJ9%2B34vND8hha%2BXOcuGHTY6TSflpToAv60114tLLfCekIgGhf4397Cgun2HpEB3oHO2hQRuHjDX7%2BSkBjqlAbuJIlwQmjnxEgUXwKpASBJ7B8zgesS8cANKA4i%2FO7g0to4%2FUAhICFkVy1G%2BNLUUrVX2PAMYTAH7iMU8lWxfUcIBMmg%2BCWbL4O4CKUydbwfgojalAN8KksHf%2F3IAHJkH9OrQqG3jQxGlVDUv%2B%2B1WLYwECWczrombRpDVxBl4oX3%2Baq6pvEJdERYNgMU8zfEoOXkV8kfFx7R3utq5vt9lcnB2VDR32w%3D%3D&X-Amz-SignedHeaders=host&X-Amz-Signature=f8c04b64d57c9b317c4ccb68a7961d6aa166a61b38c52b457caf5a2f87b72dfb),\r\nI suspect that the test tries to click the saved object button when it's\r\nstill disabled.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"3d05f74cfdb1cf1083a90bbebf61094772fe3417","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Metrics UI","Team:Infra Monitoring UI","release_note:skip","backport:prev-minor","Feature:ObsHosts","v8.10.0"],"number":160504,"url":"https://github.com/elastic/kibana/pull/160504","mergeCommit":{"message":"[Infrastructure UI] Metrics Explorer Saved View flaky test fix (#160504)\n\ncloses [#156513](https://github.com/elastic/kibana/issues/156513)\r\n\r\n## Summary\r\n\r\nFix flaky Metrics Explorer Saved Views functional test. Based on the\r\n[screenshot](https://buildkiteartifacts.com/e0f3970e-3a75-4621-919f-e6c773e2bb12/b1106efc-ba5e-4e90-a857-11c4a899c05d/0188e3a3-7b0a-4a2b-b305-41f088a36c7b/0188e3a5-5e7d-4cac-9ca2-ad049aa86341/x-pack/test/functional/screenshots/failure/InfraOps%20App%20Metrics%20UI%20Metrics%20Explorer%20Saved%20Views%20should%20update%20the%20current%20s-548c19241effa693af1bdaa2945c1bb8f7a0de0759993758d705b60a14e17c8d.png?response-content-type=image%2Fpng&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=ASIAQPCP3C7LZDIHP4OQ%2F20230626%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20230626T100738Z&X-Amz-Expires=600&X-Amz-Security-Token=IQoJb3JpZ2luX2VjENf%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLWVhc3QtMSJHMEUCIQCWRh%2Bz%2BuUkCNazAWmBVuDmsKyUAOlJ%2F71ynwSjXcFzGwIgBwzs5UgxrUrkki2Bl7ucYrIa0ldQYroVGWCAyxTTGLMq8QMIQBAAGgwwMzIzNzk3MDUzMDMiDMeqhNGm7I4CeupKPyrOA4mOkzowrCIJ9q06o%2B0LNAadRLnRcoUyBFNpVdOOZ0Mz8PCIQv8PxnVFC9c9b0o7zzxXhhIssuWjMG4bjR9PVgAL1xIMwVp9qmsfGELZ4Ctc5Py18PZ6Nsp0IYU9dj58bxyronawXCypdqG%2BaAfcETMYhr7IwusqJQKtJr0XvuWHAABjQp8KLfzU04sKG5XjZtaj%2F9i8ma2ubesispDhEjdsZYr9cy5dLqkHHEBfIi0WHc6wsdlrFge5LVQSe0Cppf7FhKubL39v2FcbPA58ftR075YDIFfgTh4jMaC502WmUBDEI1HhBNPBtGKJQz7gN6iYIlIfW8q1rXPW5KiLU3D%2ByjU0gWAO6xyBb8ShIwxJ8fCRFrpT4487g5VFrJCDwAmhuCpKWu4GtgsWvMr0VNB4M%2BKJKR7%2FicDIEjo6HIDJen1%2FvEwAWRQQOumf5Fpqt3tYYaEtf5BcnFM2EU1q5KQvcaBLvNeXiOBD8qYqfkiDlOc8Zl8C%2F%2FVd%2Fs6LusnDjzrCR%2BiM504i0p6dcjdpIsWQ9HSZKtqAGzJ9%2B34vND8hha%2BXOcuGHTY6TSflpToAv60114tLLfCekIgGhf4397Cgun2HpEB3oHO2hQRuHjDX7%2BSkBjqlAbuJIlwQmjnxEgUXwKpASBJ7B8zgesS8cANKA4i%2FO7g0to4%2FUAhICFkVy1G%2BNLUUrVX2PAMYTAH7iMU8lWxfUcIBMmg%2BCWbL4O4CKUydbwfgojalAN8KksHf%2F3IAHJkH9OrQqG3jQxGlVDUv%2B%2B1WLYwECWczrombRpDVxBl4oX3%2Baq6pvEJdERYNgMU8zfEoOXkV8kfFx7R3utq5vt9lcnB2VDR32w%3D%3D&X-Amz-SignedHeaders=host&X-Amz-Signature=f8c04b64d57c9b317c4ccb68a7961d6aa166a61b38c52b457caf5a2f87b72dfb),\r\nI suspect that the test tries to click the saved object button when it's\r\nstill disabled.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"3d05f74cfdb1cf1083a90bbebf61094772fe3417"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160504","number":160504,"mergeCommit":{"message":"[Infrastructure UI] Metrics Explorer Saved View flaky test fix (#160504)\n\ncloses [#156513](https://github.com/elastic/kibana/issues/156513)\r\n\r\n## Summary\r\n\r\nFix flaky Metrics Explorer Saved Views functional test. Based on the\r\n[screenshot](https://buildkiteartifacts.com/e0f3970e-3a75-4621-919f-e6c773e2bb12/b1106efc-ba5e-4e90-a857-11c4a899c05d/0188e3a3-7b0a-4a2b-b305-41f088a36c7b/0188e3a5-5e7d-4cac-9ca2-ad049aa86341/x-pack/test/functional/screenshots/failure/InfraOps%20App%20Metrics%20UI%20Metrics%20Explorer%20Saved%20Views%20should%20update%20the%20current%20s-548c19241effa693af1bdaa2945c1bb8f7a0de0759993758d705b60a14e17c8d.png?response-content-type=image%2Fpng&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=ASIAQPCP3C7LZDIHP4OQ%2F20230626%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20230626T100738Z&X-Amz-Expires=600&X-Amz-Security-Token=IQoJb3JpZ2luX2VjENf%2F%2F%2F%2F%2F%2F%2F%2F%2F%2FwEaCXVzLWVhc3QtMSJHMEUCIQCWRh%2Bz%2BuUkCNazAWmBVuDmsKyUAOlJ%2F71ynwSjXcFzGwIgBwzs5UgxrUrkki2Bl7ucYrIa0ldQYroVGWCAyxTTGLMq8QMIQBAAGgwwMzIzNzk3MDUzMDMiDMeqhNGm7I4CeupKPyrOA4mOkzowrCIJ9q06o%2B0LNAadRLnRcoUyBFNpVdOOZ0Mz8PCIQv8PxnVFC9c9b0o7zzxXhhIssuWjMG4bjR9PVgAL1xIMwVp9qmsfGELZ4Ctc5Py18PZ6Nsp0IYU9dj58bxyronawXCypdqG%2BaAfcETMYhr7IwusqJQKtJr0XvuWHAABjQp8KLfzU04sKG5XjZtaj%2F9i8ma2ubesispDhEjdsZYr9cy5dLqkHHEBfIi0WHc6wsdlrFge5LVQSe0Cppf7FhKubL39v2FcbPA58ftR075YDIFfgTh4jMaC502WmUBDEI1HhBNPBtGKJQz7gN6iYIlIfW8q1rXPW5KiLU3D%2ByjU0gWAO6xyBb8ShIwxJ8fCRFrpT4487g5VFrJCDwAmhuCpKWu4GtgsWvMr0VNB4M%2BKJKR7%2FicDIEjo6HIDJen1%2FvEwAWRQQOumf5Fpqt3tYYaEtf5BcnFM2EU1q5KQvcaBLvNeXiOBD8qYqfkiDlOc8Zl8C%2F%2FVd%2Fs6LusnDjzrCR%2BiM504i0p6dcjdpIsWQ9HSZKtqAGzJ9%2B34vND8hha%2BXOcuGHTY6TSflpToAv60114tLLfCekIgGhf4397Cgun2HpEB3oHO2hQRuHjDX7%2BSkBjqlAbuJIlwQmjnxEgUXwKpASBJ7B8zgesS8cANKA4i%2FO7g0to4%2FUAhICFkVy1G%2BNLUUrVX2PAMYTAH7iMU8lWxfUcIBMmg%2BCWbL4O4CKUydbwfgojalAN8KksHf%2F3IAHJkH9OrQqG3jQxGlVDUv%2B%2B1WLYwECWczrombRpDVxBl4oX3%2Baq6pvEJdERYNgMU8zfEoOXkV8kfFx7R3utq5vt9lcnB2VDR32w%3D%3D&X-Amz-SignedHeaders=host&X-Amz-Signature=f8c04b64d57c9b317c4ccb68a7961d6aa166a61b38c52b457caf5a2f87b72dfb),\r\nI suspect that the test tries to click the saved object button when it's\r\nstill disabled.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"3d05f74cfdb1cf1083a90bbebf61094772fe3417"}}]}] BACKPORT--> Co-authored-by: Carlos Crespo <[email protected]>
,\r\nI){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #156513
Summary
Fix flaky Metrics Explorer Saved Views functional test. Based on the screenshot, I suspect that the test tries to click the saved object button when it's still disabled.