[Response Ops][Alerting] Updating AlertsClient to provide feature parity with rule registry lifecycle executor

packages/kbn-alerts-as-data-utils/src/field_maps/alert_field_map.ts

@@ -37,6 +37,9 @@ import {
   SPACE_IDS,
   TIMESTAMP,
   VERSION,
+  EVENT_ACTION,
+  EVENT_KIND,
+  TAGS,
 } from '@kbn/rule-data-utils';
 
 export const alertFieldMap = {
@@ -179,11 +182,26 @@ export const alertFieldMap = {
     array: true,
     required: false,
   },
+  [EVENT_ACTION]: {
+    type: 'keyword',
+    array: false,
+    required: false,
+  },
+  [EVENT_KIND]: {
+    type: 'keyword',
+    array: false,
+    required: false,
+  },
   [SPACE_IDS]: {
     type: 'keyword',
     array: true,
     required: true,
   },
+  [TAGS]: {
+    type: 'keyword',
+    array: true,
+    required: false,
+  },
   [TIMESTAMP]: {
     type: 'date',
     required: true,

packages/kbn-alerts-as-data-utils/src/field_maps/legacy_alert_field_map.ts

@@ -35,9 +35,6 @@ import {
   ALERT_WORKFLOW_REASON,
   ALERT_WORKFLOW_USER,
   ECS_VERSION,
-  EVENT_ACTION,
-  EVENT_KIND,
-  TAGS,
 } from '@kbn/rule-data-utils';
 
 export const legacyAlertFieldMap = {
@@ -182,21 +179,6 @@ export const legacyAlertFieldMap = {
     array: false,
     required: false,
   },
-  [EVENT_ACTION]: {
-    type: 'keyword',
-    array: false,
-    required: false,
-  },
-  [EVENT_KIND]: {
-    type: 'keyword',
-    array: false,
-    required: false,
-  },
-  [TAGS]: {
-    type: 'keyword',
-    array: true,
-    required: false,
-  },
 } as const;
 
 export type LegacyAlertFieldMap = typeof legacyAlertFieldMap;

packages/kbn-alerts-as-data-utils/src/schemas/generated/alert_schema.ts

@@ -89,6 +89,10 @@ const AlertRequired = rt.type({
   }),
 });
 const AlertOptional = rt.partial({
+  event: rt.partial({
+    action: schemaString,
+    kind: schemaString,
+  }),
   kibana: rt.partial({
     alert: rt.partial({
       action_group: schemaString,
@@ -117,6 +121,7 @@ const AlertOptional = rt.partial({
     }),
     version: schemaString,
   }),
+  tags: schemaStringArray,
 });
 
 // prettier-ignore

packages/kbn-alerts-as-data-utils/src/schemas/generated/legacy_alert_schema.ts

@@ -72,10 +72,6 @@ const LegacyAlertOptional = rt.partial({
   ecs: rt.partial({
     version: schemaString,
   }),
-  event: rt.partial({
-    action: schemaString,
-    kind: schemaString,
-  }),
   kibana: rt.partial({
     alert: rt.partial({
       risk_score: schemaNumber,
@@ -113,7 +109,6 @@ const LegacyAlertOptional = rt.partial({
       workflow_user: schemaString,
     }),
   }),
-  tags: schemaStringArray,
 });
 
 // prettier-ignore

x-pack/plugins/alerting/common/alert_schema/field_maps/mapping_from_field_map.test.ts

@@ -190,6 +190,16 @@ describe('mappingFromFieldMap', () => {
         '@timestamp': {
           type: 'date',
         },
+        event: {
+          properties: {
+            action: {
+              type: 'keyword',
+            },
+            kind: {
+              type: 'keyword',
+            },
+          },
+        },
         kibana: {
           properties: {
             alert: {
@@ -305,6 +315,9 @@ describe('mappingFromFieldMap', () => {
             },
           },
         },
+        tags: {
+          type: 'keyword',
+        },
       },
     });
     expect(mappingFromFieldMap(legacyAlertFieldMap)).toEqual({
@@ -355,8 +368,6 @@ describe('mappingFromFieldMap', () => {
           },
         },
         ecs: { properties: { version: { type: 'keyword' } } },
-        event: { properties: { action: { type: 'keyword' }, kind: { type: 'keyword' } } },
-        tags: { type: 'keyword' },
       },
     });
   });

x-pack/plugins/alerting/server/alert/alert.test.ts

@@ -250,6 +250,24 @@ describe('getUUID()', () => {
   });
 });
 
+describe('getStart()', () => {
+  test('returns null for new alert', () => {
+    const alert = new Alert<AlertInstanceState, AlertInstanceContext, DefaultActionGroupId>('1');
+    expect(alert.getStart()).toBeNull();
+  });
+
+  test('returns start time if set in state', () => {
+    const uuid = 'previous-uuid';
+    const meta = { uuid };
+    const state = { foo: true, start: '2023-03-28T12:27:28.159Z', duration: '0' };
+    const alert = new Alert<AlertInstanceState, AlertInstanceContext, DefaultActionGroupId>('1', {
+      state,
+      meta,
+    });
+    expect(alert.getStart()).toEqual('2023-03-28T12:27:28.159Z');
+  });
+});
+
 describe('scheduleActions()', () => {
   test('makes hasScheduledActions() return true', () => {
     const alert = new Alert<AlertInstanceState, AlertInstanceContext, DefaultActionGroupId>('1', {

x-pack/plugins/alerting/server/alert/alert.ts

@@ -39,6 +39,7 @@ export type PublicAlert<
   | 'getContext'
   | 'getState'
   | 'getUuid'
+  | 'getStart'
   | 'hasContext'
   | 'replaceState'
   | 'scheduleActions'
@@ -76,6 +77,10 @@ export class Alert<
     return this.meta.uuid!;
   }
 
+  getStart(): string | null {
+    return this.state.start ? `${this.state.start}` : null;
+  }
+
   hasScheduledActions() {
     return this.scheduledExecutionOptions !== undefined;
   }