[Asset Manager] services endpoint #160294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
klacabane
added
Team:Infra Monitoring UI - DEPRECATED
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
delanni
reviewed
Jun 28, 2023
| @@ -74,9 +74,6 @@ disabled: | |||
| # Scalability testing config that we run in its own pipeline | |||
| - x-pack/test/scalability/config.ts | |||
|
|
|||
| # Asset Manager configs, in tech preview, will move to enabled after more stability introduced | |||
| - x-pack/test/api_integration/apis/asset_manager/config.ts | |||
There was a problem hiding this comment.
I don't see it based on the description: why is this test removed?
There was a problem hiding this comment.
It is removed from the disabled block and added to enabled
delanni
approved these changes
Jul 3, 2023
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
|
I think we should expose a public client to get the services as part of this PR. What do you think? |
|
Good call for the client, but I'd be inclined to implement it as a separate change since it will also need to expose the /hosts endpoint |
|
@elasticmachine merge upstream |
klacabane
added a commit
that referenced
this pull request
Aug 17, 2023
## Summary Closes #161887 Merges most of the functionality from `feat/obs-asset-manager-demo` branch. We remove implicit collection code while including: - asset collectors from signals (also include pods and containers but we don't use then directly) - source configuration code (assets or signals) - `assetAccessor` logic that determines which indices to query The change also enables ftr test suite. We'll also merge the services endpoint #160294 when approved. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Jason Rhodes <[email protected]>
neptunian
approved these changes
Aug 17, 2023
klacabane
added a commit
to klacabane/kibana
that referenced
this pull request
Aug 17, 2023
Closes elastic#159641 Implements `/assets/services` endpoint that returns service assets found in the configured source (signals or assets indices). Consumer can provide a `parent` query to filter the returned services. While the _assets_ mode supports any kind of parent/depth thanks to its common interface, the _signals_ mode only supports host parent for the moment. 1. pull this branch and point it at an oblt-cli created cluster that uses cross-cluster search to read from the edge cluster 2. add the following[1] to your kibana.yml file 3. hit `/api/asset-manager/assets/services?from=<from>&to=<to>&(parent=<host>)?`. services should be returned. Add/remove parent query string to filter services only running on specific host. 4. update `lockedSource: assets` to read from assets generated by implicit collection 5. repeat 3. [1] ``` xpack.assetManager: alphaEnabled: true sourceIndices: metrics: remote_cluster:metricbeat*,remote_cluster:metrics-* logs: remote_cluster:filebeat*,remote_cluster:logs-* traces: remote_cluster:traces-* serviceMetrics: remote_cluster:metrics-apm* serviceLogs: remote_cluster:logs-apm* lockedSource: signals ``` --------- Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #159641
Implements
/assets/servicesendpoint that returns service assets found in the configured source (signals or assets indices). Consumer can provide aparentquery to filter the returned services. While the assets mode supports any kind of parent/depth thanks to its common interface, the signals mode only supports host parent for the moment.Testing
/api/asset-manager/assets/services?from=<from>&to=<to>&(parent=<host>)?. services should be returned. Add/remove parent query string to filter services only running on specific host.lockedSource: assetsto read from assets generated by implicit collection[1]