Telemetry for Global Search #160224
Merged
Telemetry for Global Search #160224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
commented
Jun 22, 2023
tsullivan
force-pushed
the
serverless/add-global-search-telemetry
branch
7 times, most recently
from
5f79d3f to
147ecd0
Compare
tsullivan
force-pushed
the
serverless/add-global-search-telemetry
branch
from
147ecd0 to
eb29ae5
Compare
tsullivan
changed the title
tsullivan
added
Team:SharedUX
tsullivan
added
the
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
…sullivan/kibana into serverless/add-global-search-telemetry
sebelga
reviewed
Jun 26, 2023
| public searchFocus() { | ||
| this.trackUiMetric(METRIC_TYPE.COUNT, CountMetric.SEARCH_FOCUS); | ||
|
|
||
| this.focusStart = new Date(Date.now()).valueOf(); |
There was a problem hiding this comment.
Why not simply: this.focusStart = Date.now(); 😊 Same on L71
sebelga
reviewed
Jun 26, 2023
| public searchBlur() { | ||
| const focusTime = new Date(Date.now()).valueOf() - this.focusStart; | ||
| if (focusTime > 0) { | ||
| this.deps.analytics.reportEvent(EventMetric.SEARCH_BLUR, { |
There was a problem hiding this comment.
nit: the same way you have an alias for this.tracUiMetric we could have an alias of this.deps.analytics.reportEvent in this.reportEvent?
sebelga
reviewed
Jun 26, 2023
| const createBatch = (...results: Result[]): GlobalSearchBatchedResults => ({ | ||
| results: results.map(createResult), | ||
| }); | ||
| jest.useFakeTimers({ legacyFakeTimers: true }); |
There was a problem hiding this comment.
I never know if this affects other tests 😊 So I put it in a beforeAll and then in an afterAll I call jest. useRealTimers() ... just in case
tsullivan
force-pushed
the
serverless/add-global-search-telemetry
branch
from
0330eb2 to
982633d
Compare
|
Thanks @seb. I agreed with your feedback and have addressed it. Would you mind taking another look? |
💚 Build Succeeded
Metrics [docs]Module Count
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @tsullivan |
rshen91
approved these changes
Jun 27, 2023
kibanamachine
added
v8.10.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #158880
global_search_bar_click_applicationglobal_search_bar_click_saved_objectglobal_search_bar_blurglobal_search_bar_errorapplication: stringsaved_object_type: stringterms: stringselected_rank: numberselected_label: stringfocus_time_ms: numbererror_messageNOTE: The "blur" event needs to be created any time the user dismisses the search bar, whether or not a selection has been made. Therefore, the action of a user selecting an option in the global search will yield two separate events.
Checklist
Delete any items that are not applicable to this PR.