Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Filters tls certs by saved objects #160113

Merged
merged 8 commits into from
Jun 21, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jun 21, 2023

Summary

Testing

  1. Create few http monitors in default space
  2. Make sure you can see tls certificates related to those in tls certs page
  3. Switch to some other space, and you shouldn't see tls certs related to default space in that other space
image

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.9.0 labels Jun 21, 2023
@shahzad31 shahzad31 marked this pull request as ready for review June 21, 2023 10:49
@shahzad31 shahzad31 requested a review from a team as a code owner June 21, 2023 10:49
Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it LGTM.

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jun 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 1270 1275 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.2MB 1.2MB +945.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 416 420 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 497 501 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 79d8349 into elastic:main Jun 21, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 21, 2023
@shahzad31 shahzad31 deleted the fix-certs-filtering branch June 21, 2023 20:04
@shahzad31
Copy link
Contributor Author

POST FF LGTM except a small follow up PR #160901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants