[Security Solution] [Detections] amends useFetchIndex hook to accept data view id in addition to array of index names #160079

dhurley14 · 2023-06-20T20:14:28Z

Summary

Please read for more background on motivations for this PR -> #154968

updates useFetchIndex hook to accept a data view id in addition to an array of index names and updates useRuleIndexPattern hook to pass in data view id to useFetchIndex.

… array of index names and updates useRuleIndexPattern hook to pass in data view id to useFetchIndex

…a into use-fetch-data-view-hook

vitaliidm · 2023-06-23T10:51:17Z

x-pack/plugins/security_solution/public/common/types.ts

+//  * @deprecated use DataViewSpec from @kbn/data-views-plugin/common
+//  * or DataView if absolutely necessary
+//  */
+// export type DataViewBase = DataViewBase;


noticed commented code in few places. Can it be removed?

x-pack/plugins/security_solution/public/detections/components/rules/step_define_rule/index.tsx

vitaliidm · 2023-06-23T11:33:13Z

x-pack/plugins/security_solution/public/detections/components/rules/description_step/index.tsx

+        pick(key, schema),
+        filterManager,
+        license,
+        dataViewInstance as DataViewBase


is this possible to avoid type castings?

Kind of the same situation as above except this is due to the unified search team's component FilterBadgeGroup needing a DataViewBase type to be passed to it, which the dataViewInstance is compatible with. Until that changes, we'll need the casting unfortunately.

vitaliidm · 2023-06-23T11:33:47Z

x-pack/plugins/security_solution/public/common/components/threat_match/entry_item.tsx

+  const dataViewInstance = useMemo(() => {
+    if (indexPattern != null) {
+      const dv = new DataView({ spec: indexPattern, fieldFormats });
+      return { ...dv, fields: Object.values(indexPattern.fields ?? {}) } as DataView;


is this possible to avoid type castings?

This is a great question - I kept these type castings because until we also update all the exceptions code to accept the DataViewSpec type, we can't update the child component FieldComponent, so once that work is completed we can remove the type castings all together which will be great. I'll add a todo to the code.

vitaliidm · 2023-06-23T11:35:53Z

x-pack/plugins/security_solution/public/common/components/threat_match/entry_item.tsx

+      const dv = new DataView({ spec: threatIndexPatterns, fieldFormats });
+      return { ...dv, fields: Object.values(threatIndexPatterns.fields ?? {}) } as DataView;
+    }
+    return [];


nit: separate transform function can be added to DataView instance from index and fields formats. dataViewInstance and threatDataViewInstance look indentical

…ewSpec

…rules/step_define_rule/index.tsx faster reduce Co-authored-by: Vitalii Dmyterko <[email protected]>

…a into use-fetch-data-view-hook

…-ref HEAD~1..HEAD --fix'

e40pud · 2023-06-23T14:31:05Z

x-pack/plugins/security_solution/public/common/containers/source/index.tsx


-          previousIndexesName.current = dv.getIndexPattern().split(',');
+          const { browserFields } = getDataViewStateFromIndexFields(iNames, dataView.fields);
+          previousIndexesNameOrId.current = dataView?.title?.split(',');


should not this previousIndexesNameOrId.current = dataView?.title?.split(','); be within previous else branch? it will always override line 136

e40pud · 2023-06-23T14:44:13Z

x-pack/plugins/security_solution/public/detections/components/rules/step_define_rule/index.tsx

+              acc.keywordFields.push({ label: field.name });
+            } else if (field.type === 'date') {
+              acc.dateFields.push({ label: field.name });
+            } else if (field.type !== 'date') {


Can be just } else {?

…a into use-fetch-data-view-hook

dhurley14 · 2023-06-23T18:52:59Z

cypress tests were failing because of a missing dependency here: #160445 once that is merged I'll update this PR and hopefully that fixes a few of the failures.

…-hook

kibana-ci · 2023-06-24T04:09:17Z

💔 Build Failed

Failed CI Steps

Test Failures

[job] [logs] Security Solution Tests #6 / Detections : Page Filters Alert list is updated when the alerts are updated
[job] [logs] Security Solution Tests #6 / Detections : Page Filters Impact of inputs should recover from invalide kql Query result
[job] [logs] Security Solution Tests #5 / EQL rules Detection rules, EQL Creates and enables a new EQL rule
[job] [logs] Security Solution Tests #5 / EQL rules Detection rules, EQL Creates and enables a new EQL rule
[job] [logs] Defend Workflows Cypress Tests #1 / Response console suspend-process command "after all" hook for "should suspend process from response console"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	11.0MB	11.0MB	+3.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	52.2KB	52.3KB	+139.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	14	16	+2
`securitySolution`	416	420	+4
total			+6

References to deprecated APIs

id	before	after	diff
`securitySolution`	614	605	-9

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	15	17	+2
`securitySolution`	497	501	+4
total			+6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dhurley14

dplumlee · 2023-06-30T17:20:34Z

x-pack/plugins/security_solution/public/common/containers/source/index.tsx

 }

 /**
 * Independent index fields hook/request
 * returns state directly, no redux
 */
 export const useFetchIndex = (
-  indexNames: string[],
+  indexNamesOrDvId: string | string[],


If we're trying to move away from the indexNames pattern, would it be better to just construct a new param structure and separate these two arguments instead of delineating on isArray? I understand that would cause a lot of refactor since we use this hook everywhere, but just wondering what your thoughts were. Having multiple variables in this function logic with "or" in the name reads a bit confusing

PhilippeOberti · 2023-12-14T22:49:45Z

@dhurley14 is this PR still being worked on or can it be closed?

PhilippeOberti · 2024-01-08T20:34:32Z

@dhurley14 is this PR still being worked on or can it be closed?

PhilippeOberti · 2024-02-22T16:45:55Z

@dhurley14 is this PR still being worked on or can it be closed?

PhilippeOberti · 2024-06-26T12:51:37Z

@dhurley14 is this PR still being worked on or can it be closed?

dhurley14 · 2024-06-27T12:11:20Z

@PhilippeOberti Hi 👋 I will close this out. Hopefully myself or someone can pick this issue back up in the future. I think it is worth it as part of the cleanup work with sourcerer.

dhurley14 added 6 commits June 20, 2023 16:12

updates useFetchIndex hook to accept a data view id in addition to an…

0e103ae

… array of index names and updates useRuleIndexPattern hook to pass in data view id to useFetchIndex

Merge branch 'main' into use-fetch-data-view-hook

be39923

Merge branch 'main' into use-fetch-data-view-hook

7fa2b7e

updates rules to use dataviewspec, need to update jest tests still

a76d648

Merge branch 'use-fetch-data-view-hook' of github.com:dhurley14/kiban…

736a59f

…a into use-fetch-data-view-hook

fixes type errors in tests

8f427be

dhurley14 self-assigned this Jun 22, 2023

Merge branch 'main' into use-fetch-data-view-hook

ba8a2ea

dhurley14 changed the title ~~updates useFetchIndex hook to accept a data view id in addition to an…~~ [Security Solution] [Detections] amends useFetchIndex hook to accept data view id in addition to array of index names Jun 22, 2023

dhurley14 added review release_note:skip Skip the PR/issue when compiling release notes Team:Security Solution Platform Security Solution Platform Team Team:Detection Engine Security Solution Detection Engine Area v8.10.0 labels Jun 22, 2023

dhurley14 marked this pull request as ready for review June 22, 2023 19:13

dhurley14 requested review from a team as code owners June 22, 2023 19:13

dhurley14 requested a review from dplumlee June 22, 2023 19:13

dhurley14 mentioned this pull request Jun 22, 2023

[Security Solution] [Platform] updates useFetchIndex hook to accept data view id in addition to array of index names #155900

Closed

e40pud self-requested a review June 23, 2023 09:17

vitaliidm reviewed Jun 23, 2023

View reviewed changes

dhurley14 and others added 5 commits June 23, 2023 10:18

adds todo for removing as casting once exceptions code accepts DataVi…

0747d1a

…ewSpec

Update x-pack/plugins/security_solution/public/detections/components/…

bdcb250

…rules/step_define_rule/index.tsx faster reduce Co-authored-by: Vitalii Dmyterko <[email protected]>

removes commented import statements

8c63fbc

Merge branch 'use-fetch-data-view-hook' of github.com:dhurley14/kiban…

736753e

…a into use-fetch-data-view-hook

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

5fef369

…-ref HEAD~1..HEAD --fix'

e40pud reviewed Jun 23, 2023

View reviewed changes

add snapshot test

9576fde

Merge branch 'use-fetch-data-view-hook' of github.com:dhurley14/kiban…

ec7f168

…a into use-fetch-data-view-hook

dhurley14 added 2 commits June 23, 2023 17:16

Merge remote-tracking branch 'upstream/main' into use-fetch-data-view…

8b7bf94

…-hook

Merge branch 'main' into use-fetch-data-view-hook

7cebe11

dplumlee reviewed Jun 30, 2023

View reviewed changes

dhurley14 mentioned this pull request Aug 31, 2023

[Security Solution] [Detections] Adds support for index patterns (DataViewBase) to be used for query bar filters #165262

Merged

dhurley14 closed this Jun 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] [Detections] amends useFetchIndex hook to accept data view id in addition to array of index names #160079

[Security Solution] [Detections] amends useFetchIndex hook to accept data view id in addition to array of index names #160079

dhurley14 commented Jun 20, 2023 •

edited

Loading

vitaliidm Jun 23, 2023

vitaliidm Jun 23, 2023

dhurley14 Jun 23, 2023

vitaliidm Jun 23, 2023

dhurley14 Jun 23, 2023

vitaliidm Jun 23, 2023

e40pud Jun 23, 2023

e40pud Jun 23, 2023

dhurley14 commented Jun 23, 2023

kibana-ci commented Jun 24, 2023 •

edited

Loading

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

dplumlee Jun 30, 2023 •

edited

Loading

PhilippeOberti commented Dec 14, 2023

PhilippeOberti commented Jan 8, 2024

PhilippeOberti commented Feb 22, 2024

PhilippeOberti commented Jun 26, 2024

dhurley14 commented Jun 27, 2024

[Security Solution] [Detections] amends useFetchIndex hook to accept data view id in addition to array of index names #160079

[Security Solution] [Detections] amends useFetchIndex hook to accept data view id in addition to array of index names #160079

Conversation

dhurley14 commented Jun 20, 2023 • edited Loading

Summary

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dhurley14 commented Jun 23, 2023

kibana-ci commented Jun 24, 2023 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Page load bundle

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

History

dplumlee Jun 30, 2023 • edited Loading

Choose a reason for hiding this comment

PhilippeOberti commented Dec 14, 2023

PhilippeOberti commented Jan 8, 2024

PhilippeOberti commented Feb 22, 2024

PhilippeOberti commented Jun 26, 2024

dhurley14 commented Jun 27, 2024

dhurley14 commented Jun 20, 2023 •

edited

Loading

kibana-ci commented Jun 24, 2023 •

edited

Loading

dplumlee Jun 30, 2023 •

edited

Loading