Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[home] Add target=_blank to all markdown links #15995

Merged
merged 3 commits into from
Jan 11, 2018

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 11, 2018

Add target=_blank to all markdown links in home tutorials

Part of #15961

@nreese nreese requested a review from kobelb January 11, 2018 16:07
@timroes
Copy link
Contributor

timroes commented Jan 11, 2018

@nreese
Copy link
Contributor Author

nreese commented Jan 11, 2018

thanks @timroes

@kobelb
Copy link
Contributor

kobelb commented Jan 11, 2018

@nreese the jest snapshot needs to be updated after adding the rel attributes

Copy link
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nreese nreese merged commit 9ccc963 into elastic:master Jan 11, 2018
nreese added a commit to nreese/kibana that referenced this pull request Jan 11, 2018
* Add target=_blank to all markdown links

* add rel property

* fix jest test
nreese added a commit that referenced this pull request Jan 12, 2018
* Add target=_blank to all markdown links

* add rel property

* fix jest test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants