Use euiCallOut for experimental banner #15989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timroes
added
Feature:Visualizations
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Jan 11, 2018
timroes
added a commit
that referenced
this pull request
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15713
As discussed in this ticket, we use the
euiCallOutclasses to style the "experimental banner" above the editor. I also added the icon as suggested by the design team.The way it will look in the end:
Currently the small padding variant hasn't been release and I am not sure if the design team will release another eui version before 6.2. While we are running on the current EUI version, the banner still has a bit more padding:
But I already added the classes for the small padding, so as soon as EUI releases a new version, and that is used in Kibana, it will change to the small padding as seen in the first screenshot.