-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Security][Vulnerabilities] Resource page #159873
[Cloud Security][Vulnerabilities] Resource page #159873
Conversation
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (checked locally),
@Omolola-Akinleye I would appriciate if you would review this as well, even if already merged
</EuiTab> | ||
<EuiTab | ||
key="configurations" | ||
onClick={navigateToConfigurationsTab} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Also, this may be a UX/Technical Debt item and separate filter persistence for Vulnerability Findings from Misconfigurations. Currently, filters persist when navigating between tabs for Vulnerabilities and Misconfigurations. The user has to reset filter tabs each time. @opauloh @kfirpeled @JordanSh
Summary
it closes #158042
This PR adds the Vulnerabilities Resource page, as well as navigation from the Vulnerabilities Group By Resource page. It also:
useFilteredDataView
hook, which was causing the Search bar to now show all the available fields after the recent changes removing some fields inelastic/integration
.Screenshot
Group by resource page
Vulnerability Resource page
Removed header from Findings Resource page: