Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security][Vulnerabilities] Resource page #159873

Merged
merged 9 commits into from
Jun 19, 2023

Conversation

opauloh
Copy link
Contributor

@opauloh opauloh commented Jun 16, 2023

Summary

it closes #158042

This PR adds the Vulnerabilities Resource page, as well as navigation from the Vulnerabilities Group By Resource page. It also:

  • Adds utility function for Vulnerability columns grid
  • Fixes the useFilteredDataView hook, which was causing the Search bar to now show all the available fields after the recent changes removing some fields in elastic/integration .
  • Reduces title from both resources pages size to match design.
  • Updates back to resources button to be on top again.
  • Address some misalignment issues on the vulnerabilities table.

Screenshot

Group by resource page

image

Vulnerability Resource page

image

Removed header from Findings Resource page:

image

@opauloh opauloh requested a review from a team as a code owner June 16, 2023 22:48
@opauloh opauloh added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related labels Jun 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@opauloh opauloh added release_note:feature Makes this part of the condensed release notes v8.9.0 and removed release_note:skip Skip the PR/issue when compiling release notes labels Jun 16, 2023
@opauloh opauloh requested a review from Omolola-Akinleye June 16, 2023 22:50
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 196 198 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 209.0KB 215.7KB +6.7KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 411 415 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 494 498 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@kfirpeled kfirpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (checked locally),

@Omolola-Akinleye I would appriciate if you would review this as well, even if already merged

@opauloh opauloh merged commit 0163bf3 into elastic:main Jun 19, 2023
@opauloh opauloh deleted the cnvm/vulnerabilities-resource-page branch June 19, 2023 15:44
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 19, 2023
</EuiTab>
<EuiTab
key="configurations"
onClick={navigateToConfigurationsTab}
Copy link
Contributor

@Omolola-Akinleye Omolola-Akinleye Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also, this may be a UX/Technical Debt item and separate filter persistence for Vulnerability Findings from Misconfigurations. Currently, filters persist when navigating between tabs for Vulnerabilities and Misconfigurations. The user has to reset filter tabs each time. @opauloh @kfirpeled @JordanSh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:Cloud Security Cloud Security team related v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cloud Security] [CNVM] Group by res. - Show resource's vulnerabilities table (Phase 1)
6 participants