Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(slo): improve index selection #159849

Merged
merged 6 commits into from
Jun 20, 2023

Conversation

kdelemme
Copy link
Contributor

@kdelemme kdelemme commented Jun 15, 2023

Resolves #159423

📝 Summary

This PR changes the index selection component behaviours. We are fetching the Data Views (limit to 10 at a time). The user can select one of them, or search for other Data Views and index pattern that matches at least on index.

Therefore the user can choose any Data Views matching a search, or the index pattern derived from the search, if it matches at least one index.

Screenshot
image
image
image

🧪 Testing

  1. Create 11 data views or more
    Easiest method is to use curl with a POST on /api/data_views/data_view with a random payload:
{
  "data_view": {
     "title": "{% uuid 'v4' %}-log*",
     "name": "{% uuid 'v4' %} "
  }
}
  1. Go to the SLO form and select custom KQL, then search for a data view or another index pattern

@kdelemme kdelemme self-assigned this Jun 15, 2023
@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0 labels Jun 15, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme kdelemme force-pushed the improve-index-selection branch from 43b1f63 to 4ec909c Compare June 19, 2023 12:44
@kdelemme kdelemme force-pushed the improve-index-selection branch from 6f3f96c to 80cf142 Compare June 19, 2023 14:12
@kdelemme kdelemme marked this pull request as ready for review June 19, 2023 15:46
@kdelemme kdelemme requested a review from a team as a code owner June 19, 2023 15:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.0MB 1.0MB -116.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
observability 39 38 -1
securitySolution 411 415 +4
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
observability 44 43 -1
securitySolution 494 498 +4
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

Copy link
Contributor

@CoenWarmer CoenWarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great.

@kdelemme kdelemme merged commit 12a2203 into elastic:main Jun 20, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 20, 2023
@kdelemme kdelemme deleted the improve-index-selection branch September 14, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SLO] Index selection should also show aliases
6 participants