-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(slo): improve index selection #159849
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
43b1f63
to
4ec909c
Compare
6f3f96c
to
80cf142
Compare
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @kdelemme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works great.
Resolves #159423
📝 Summary
This PR changes the index selection component behaviours. We are fetching the Data Views (limit to 10 at a time). The user can select one of them, or search for other Data Views and index pattern that matches at least on index.
Therefore the user can choose any Data Views matching a search, or the index pattern derived from the search, if it matches at least one index.
🧪 Testing
Easiest method is to use curl with a POST on
/api/data_views/data_view
with a random payload: