Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.8] [Dashboard] Fix Time Range Regression (#159337) #159844

Closed

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.8:

Questions ?

Please refer to the Backport tool documentation

Fixed Dashboard loading with a saved time range when the URL also contains a time range.

(cherry picked from commit f60d43e)
@ThomThomson
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 19, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #43 / dashboard app - group 1 dashboard embeddable data grid are added when a cell filter is clicked
  • [job] [logs] FTR Configs #43 / dashboard app - group 1 dashboard embeddable data grid are added when a cell filter is clicked
  • [job] [logs] FTR Configs #43 / dashboard app - group 1 dashboard embeddable data grid should expand the detail row when the toggle arrow is clicked
  • [job] [logs] FTR Configs #43 / dashboard app - group 1 dashboard embeddable data grid should expand the detail row when the toggle arrow is clicked
  • [job] [logs] FTR Configs #43 / dashboard app - group 1 dashboard embeddable rendering panels are updated when time changes outside of data
  • [job] [logs] FTR Configs #43 / dashboard app - group 1 dashboard embeddable rendering panels are updated when time changes outside of data
  • [job] [logs] FTR Configs #10 / dashboard app - group 1 legacy urls kibana link redirect redirects from legacy hash in wrong app
  • [job] [logs] FTR Configs #10 / dashboard app - group 1 legacy urls kibana link redirect redirects from legacy hash in wrong app
  • [job] [logs] FTR Configs #10 / dashboard app - group 1 legacy urls kibana link redirect redirects from old kibana app URL
  • [job] [logs] FTR Configs #10 / dashboard app - group 1 legacy urls kibana link redirect redirects from old kibana app URL
  • [job] [logs] FTR Configs #10 / dashboard app - group 1 legacy urls kibana link redirect resolves markdown link
  • [job] [logs] FTR Configs #10 / dashboard app - group 1 legacy urls kibana link redirect resolves markdown link
  • [job] [logs] FTR Configs #10 / dashboard app - group 1 legacy urls kibana link redirect resolves markdown link from dashboard
  • [job] [logs] FTR Configs #10 / dashboard app - group 1 legacy urls kibana link redirect resolves markdown link from dashboard
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard filter bar filter pills are added when a pie chart slice is clicked
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard filter bar filter pills are added when a pie chart slice is clicked
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard filter bar filter pills are preserved after opening a dashboard saved with filters
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard filter bar filter pills are preserved after opening a dashboard saved with filters
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard filter bar filter pills are preserved after saving a dashboard
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard filter bar filter pills are preserved after saving a dashboard
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard filter bar filter pills navigating to a dashboard with global filter doesn't unpin it if same filter is saved with dashboard
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard filter bar filter pills navigating to a dashboard with global filter doesn't unpin it if same filter is saved with dashboard
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard filter bar filter pills pinned filters aren't saved
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard filter bar filter pills pinned filters aren't saved
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard filter bar filter pills restoring filters doesn't break back button
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard filter bar filter pills restoring filters doesn't break back button
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard filter bar filter pills saving with pinned filter doesn't unpin them
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard filter bar filter pills saving with pinned filter doesn't unpin them
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard filtering adding a filter that excludes all data tsvb metric is filtered
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard filtering adding a filter that excludes all data tsvb metric is filtered
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard view edit mode and preserves edits on cancel when time changed is stored with dashboard
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard view edit mode and preserves edits on cancel when time changed is stored with dashboard
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard view edit mode shows lose changes warning and loses changes on confirmation when time changed is stored with dashboard
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard view edit mode shows lose changes warning and loses changes on confirmation when time changed is stored with dashboard
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard view edit mode shows lose changes warning and preserves edits on cancel when time changed is stored with dashboard
  • [job] [logs] FTR Configs #5 / dashboard app - group 2 dashboard view edit mode shows lose changes warning and preserves edits on cancel when time changed is stored with dashboard
  • [job] [logs] FTR Configs #9 / dashboard app - group 3 dashboard time picker Saved search updated when time picker changes
  • [job] [logs] FTR Configs #60 / dashboard app - group 3 dashboard time picker Saved search updated when time picker changes
  • [job] [logs] FTR Configs #9 / dashboard app - group 3 dashboard time picker Saved search updated when time picker changes
  • [job] [logs] FTR Configs #60 / dashboard app - group 3 dashboard time picker Saved search updated when time picker changes
  • [job] [logs] FTR Configs #9 / dashboard app - group 3 dashboard time picker Visualization updated when time picker changes
  • [job] [logs] FTR Configs #60 / dashboard app - group 3 dashboard time picker Visualization updated when time picker changes
  • [job] [logs] FTR Configs #9 / dashboard app - group 3 dashboard time picker Visualization updated when time picker changes
  • [job] [logs] FTR Configs #60 / dashboard app - group 3 dashboard time picker Visualization updated when time picker changes
  • [job] [logs] FTR Configs #23 / dashboard app - group 4 dashboard time dashboard with stored timed should use saved time after time change is undone
  • [job] [logs] FTR Configs #23 / dashboard app - group 4 dashboard time dashboard with stored timed should use saved time after time change is undone
  • [job] [logs] FTR Configs #59 / dashboard drilldowns Dashboard to dashboard drilldown Create & use drilldowns test dashboard to dashboard drilldown carries over time range from source dashboard
  • [job] [logs] FTR Configs #59 / dashboard drilldowns Dashboard to dashboard drilldown Create & use drilldowns test dashboard to dashboard drilldown carries over time range from source dashboard
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Can select an option in the third Options List
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Can select an option in the third Options List
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Creating "does not exist" query from first control filters the second and third controls
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Creating "does not exist" query from first control filters the second and third controls
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Creating "exists" query from first control filters the second and third controls
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Creating "exists" query from first control filters the second and third controls
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Excluding all options of first control removes all options in second and third controls
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Excluding all options of first control removes all options in second and third controls
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Excluding selections in the first control will validate the second and third controls
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Excluding selections in the first control will validate the second and third controls
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Hierarchical chaining off Selecting an option in the first Options List will not filter the second or third controls
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Hierarchical chaining off Selecting an option in the first Options List will not filter the second or third controls
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Selecting a conflicting option in the first control will validate the second and third controls
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Selecting a conflicting option in the first control will validate the second and third controls
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Selecting an option in the first Options List will filter the second and third controls
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Selecting an option in the first Options List will filter the second and third controls
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Selecting an option in the second Options List will filter the third control
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Selecting an option in the second Options List will filter the third control
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Shows all available options in first Options List control
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Dashboard control group hierarchical chaining Shows all available options in first Options List control
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Options list control Allow expensive queries setting is off Can search options list for available options
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Options list control Allow expensive queries setting is off Can search options list for available options
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Options list control Allow expensive queries setting is off Shows available options in options list
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Options list control Allow expensive queries setting is off Shows available options in options list
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Options list control Interactions between options list and dashboard Applies query settings to controls Applies dashboard time range to options list control
  • [job] [logs] FTR Configs #26 / dashboard elements dashboard elements Controls Options list control Interactions between options list and dashboard Applies query settings to controls Applies dashboard time range to options list control
  • [job] [logs] FTR Configs #59 / dashboard Reporting Download CSV Field Formatters and Scripted Fields Download CSV export of a saved search panel
  • [job] [logs] FTR Configs #59 / dashboard Reporting Download CSV Field Formatters and Scripted Fields Download CSV export of a saved search panel
  • [job] [logs] FTR Configs #54 / discover/embeddable discover saved search embeddable can save a search embeddable with a defined rows per page number
  • [job] [logs] FTR Configs #54 / discover/embeddable discover saved search embeddable can save a search embeddable with a defined rows per page number
  • [job] [logs] FTR Configs #54 / discover/embeddable discover saved search embeddable should control columns correctly
  • [job] [logs] FTR Configs #54 / discover/embeddable discover saved search embeddable should control columns correctly
  • [job] [logs] FTR Configs #54 / discover/embeddable discover saved search embeddable should display an error
  • [job] [logs] FTR Configs #54 / discover/embeddable discover saved search embeddable should display an error
  • [job] [logs] FTR Configs #54 / discover/embeddable discover saved search embeddable should not show the full screen button
  • [job] [logs] FTR Configs #54 / discover/embeddable discover saved search embeddable should not show the full screen button
  • [job] [logs] FTR Configs #54 / discover/embeddable discover saved search embeddable should render duplicate saved search embeddables
  • [job] [logs] FTR Configs #54 / discover/embeddable discover saved search embeddable should render duplicate saved search embeddables
  • [job] [logs] FTR Configs #54 / discover/embeddable discover saved search embeddable should replace a panel with a saved search
  • [job] [logs] FTR Configs #54 / discover/embeddable discover saved search embeddable should replace a panel with a saved search
  • [job] [logs] FTR Configs #31 / embedded Lens examples show and save should save to dashboard
  • [job] [logs] FTR Configs #31 / embedded Lens examples show and save should save to dashboard
  • [job] [logs] FTR Configs #44 / machine learning - anomaly detection create jobs from lens can create multi metric job from vis with single layer
  • [job] [logs] FTR Configs #44 / machine learning - anomaly detection create jobs from lens can create multi metric job from vis with single layer
  • [job] [logs] FTR Configs #52 / machine learning embeddables anomaly charts Accessibility with multi metric job show anomaly charts
  • [job] [logs] FTR Configs #52 / machine learning embeddables anomaly charts Accessibility with multi metric job show anomaly charts

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 355.6KB 356.3KB +760.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ThomThomson

@ThomThomson
Copy link
Contributor

Closing this one due to faulty merge. Will reopen manual backport...

auto-merge was automatically disabled June 19, 2023 15:04

Pull request was closed

@ThomThomson
Copy link
Contributor

Replacing this backport with #159946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants