Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified search] Fixes the wrap problem on the filter selection modal #159376

Merged
merged 1 commit into from
Jun 12, 2023
Merged

[Unified search] Fixes the wrap problem on the filter selection modal #159376

merged 1 commit into from
Jun 12, 2023

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jun 9, 2023 •
edited
Loading

Summary

Closes #158232

Fixes the wrap problem in filter selection modal when the text field/value is very long

image

@stratoula stratoula changed the title [Unified search] Fix the wrap problem on the filter modal for large f… [Unified search] Fix the wrap problem on the filter selection modal Jun 9, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedSearch 212.2KB 212.3KB +56.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 414 418 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 498 502 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure backport:skip This commit does not require backporting Feature:Unified search Unified search related tasks v8.9.0 labels Jun 9, 2023
@stratoula stratoula marked this pull request as ready for review June 9, 2023 11:10
@stratoula stratoula requested a review from a team as a code owner June 9, 2023 11:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula stratoula changed the title [Unified search] Fix the wrap problem on the filter selection modal [Unified search] Fixes the wrap problem on the filter selection modal Jun 9, 2023
nickofthyme
nickofthyme approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM 🚢

@stratoula stratoula merged commit 7634fdd into elastic:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Unified search Unified search related tasks release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Unified search] Filters modal doesn't display well when field name is long
4 participants
@stratoula @kibana-ci @elasticmachine @nickofthyme