Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] Discover controls customization #159318

Closed

Conversation

davismcphee
Copy link
Contributor

Summary

PoC implementation of controls in Discover using the customization framework.

Checklist

For maintainers

@davismcphee davismcphee added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jun 8, 2023
@davismcphee davismcphee self-assigned this Jun 8, 2023
@davismcphee davismcphee force-pushed the discover-controls-customization branch from 0ba1171 to ac58415 Compare June 14, 2023 19:00
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 14, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #9 / test fetchAll changes of fetchStatus when starting with FetchStatus.UNINITIALIZED
  • [job] [logs] Jest Tests #9 / test fetchAll emits loading and documents on documents$ correctly
  • [job] [logs] Jest Tests #9 / test fetchAll emits loading and hit count on totalHits$ correctly
  • [job] [logs] Jest Tests #9 / test fetchAll should not set COMPLETE if an ERROR has been set on main$
  • [job] [logs] Jest Tests #9 / test fetchAll should only fail totalHits$ query not main$ for error from that query
  • [job] [logs] Jest Tests #9 / test fetchAll should use charts query to fetch total hit count when chart is visible
  • [job] [logs] Jest Tests #9 / updateVolatileSearchSource does not explicitly request fieldsFromSource when not using fields API
  • [job] [logs] Jest Tests #9 / updateVolatileSearchSource updates a given search source
  • [job] [logs] Jest Tests #9 / updateVolatileSearchSource updates a given search source when showUnmappedFields option is set to true
  • [job] [logs] Jest Tests #9 / updateVolatileSearchSource updates a given search source with the usage of the new fields api

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 423.0KB 423.4KB +423.0B
unifiedSearch 212.4KB 212.4KB +46.0B
total +469.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
unifiedSearch 34.0KB 34.0KB +36.0B

History

  • 💔 Build #133738 failed 0ba117172bbdc08695d61c8926151319fc3a37ad

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @davismcphee

@kertal
Copy link
Member

kertal commented Aug 28, 2023

Not needed anymore

@kertal kertal closed this Aug 28, 2023
@davismcphee davismcphee deleted the discover-controls-customization branch August 28, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants