Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update icons on landing page #159114

Merged
merged 5 commits into from
Jun 7, 2023
Merged

Update icons on landing page #159114

merged 5 commits into from
Jun 7, 2023

Conversation

claracruz
Copy link
Contributor

@claracruz claracruz commented Jun 6, 2023 •
edited
Loading

Fixes: #154117
Fixes: #155341

This PR updates the guided onboarding landing page icons, removes the solution badge and updates the solution view to a grouped layout so cards remain grouped on narrow screens.

Screenshots

Screenshot 2023-06-06 at 13 37 35

Narrow

Screenshot 2023-06-06 at 14 26 58

Mobile

Screenshot 2023-06-06 at 13 37 03

@claracruz claracruz added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Journey/Onboarding Platform Journey Onboarding team v8.9.0 labels Jun 6, 2023
@claracruz claracruz requested a review from a team as a code owner June 6, 2023 12:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

@claracruz claracruz mentioned this pull request Jun 6, 2023
Closed
yuliacech
yuliacech approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @claracruz!
Tested locally and all works as expected 👍

yuliacech
yuliacech reviewed Jun 7, 2023
View reviewed changes
packages/kbn-guided-onboarding/src/components/landing_page/guide_cards.constants.tsx
@@ -27,11 +27,13 @@ export interface GuideCardConstants {
// see this issue https://github.com/elastic/kibana/issues/146672
telemetryId: string;
order: number;
icon: string;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fyi I think the property order was planned to be used potentially for sorting and grouping. But it's probably not needed anymore.

alisonelizabeth
alisonelizabeth reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @claracruz! I think there might be one small regression related to the complete state not being centered. Mind taking a look?

Screenshot 2023-06-07 at 8 56 17 AM

@claracruz claracruz force-pushed the guided_onboarding/update_icons_on_landing_page branch from 6ffb7c6 to 9ed9dbc Compare June 7, 2023 14:13
@claracruz claracruz force-pushed the guided_onboarding/update_icons_on_landing_page branch from e743f20 to ab35dc7 Compare June 7, 2023 14:24
@claracruz
Copy link
Contributor Author

@elasticmachine update branch

alisonelizabeth
alisonelizabeth approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest LGTM. Thanks for fixing!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
home 159.7KB 159.9KB +173.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 413 417 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 497 501 +4
total +6

History

  • 💚 Build #132901 succeeded 6ffb7c6efd80f6eff867a1533abb65df5ac4add4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@claracruz claracruz merged commit 9adb53f into elastic:main Jun 7, 2023
@osmanis
Copy link

osmanis commented Jun 9, 2023

Is there an environment where I can take a look?

@alisonelizabeth
Copy link
Contributor

@osmanis you should be able to create a deployment on QA using the 8.9.0-SNAPSHOT version to test.

@osmanis
Copy link

osmanis commented Jun 9, 2023

I tested in QA. Looks great!!

Noticed a few small formatting issues:

  • I noticed the empty space around the top and bottom of the solution selector aren't matching. The mock has the spacing equal. Let's reduce the extra spacing above the solution filters so it matches below.
    image
  • The tile height is a bit larger than the previous version. Could we reduce the height slightly? That would help make the Kubernetes tile a little more visible because most of it currently gets cutoff when viewing the page on my laptop.
  • For Search across databases and business systems, the and needs to be on the second line just like the mock.
  • For Secure my cloud assets with cloud security posture management (CSPM), the second cloud needs to be on the first line just like the mock.

cc @cindychangy @ryankeairns

@claracruz claracruz mentioned this pull request Jun 13, 2023
Merged
claracruz added a commit that referenced this pull request Jun 13, 2023
@claracruz
Update icons on landing page tweaks (#159557)
6f94e42 
Rel: #154117

This PR applies tweaks/updates requested @
#159114 (comment)

<img width="1221" alt="Screenshot 2023-06-13 at 11 44 36"
src="https://github.com/elastic/kibana/assets/91763/5d27424d-19d9-4c0c-bc7c-d394e745af55">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliacech yuliacech yuliacech approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Journey/Onboarding Platform Journey Onboarding team v8.9.0
Projects
None yet
Milestone
No milestone
7 participants
@claracruz @elasticmachine @kibana-ci @osmanis @alisonelizabeth @yuliacech @kibanamachine