-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] [main] Elastic Security Assistant fixes #159078
[Security Solution] [main] Elastic Security Assistant fixes #159078
Conversation
elastic#159054 was merged directly to the `8.8` branch, and includes the following changes: - Changes the `New chat` button text from `New chat` to `Chat`, because a new chat context is not created if an existing chat is in progress - Updates the Data Quality dashboard user prompt to remove references to API requests - Fixes an issue where user prompts were not filtered by category
Pinging @elastic/security-solution (Team: SecuritySolution) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍 Code reviewed and tested locally -- thank you @andrew-goldstein!
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Module Count
Public APIs missing comments
Any counts in public APIs
Async chunks
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
This PR includes the same changes as #159054
It does not require a backport.
Details
#159054 was merged to the
8.8
branch, (targetingv8.8.1
), and includes the following changes:New chat
button text fromNew chat
toChat
, because a new chat context is not created if an existing chat is in progress