Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] [main] Elastic Security Assistant fixes #159078

Merged

Conversation

andrew-goldstein
Copy link
Contributor

Summary

This PR includes the same changes as #159054

It does not require a backport.

Details

#159054 was merged to the 8.8 branch, (targeting v8.8.1), and includes the following changes:

  • Changes the New chat button text from New chat to Chat, because a new chat context is not created if an existing chat is in progress
  • Updates the Data Quality dashboard user prompt to remove references to API requests
  • Fixes an issue where user prompts were not filtered by category

elastic#159054 was merged directly to the `8.8` branch, and includes the following changes:

- Changes the `New chat` button text from `New chat` to `Chat`, because a new chat context is not created if an existing chat is in progress
- Updates the Data Quality dashboard user prompt to remove references to API requests
- Fixes an issue where user prompts were not filtered by category
@andrew-goldstein andrew-goldstein added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.9.0 labels Jun 6, 2023
@andrew-goldstein andrew-goldstein requested a review from spong June 6, 2023 00:19
@andrew-goldstein andrew-goldstein requested review from a team as code owners June 6, 2023 00:19
@andrew-goldstein andrew-goldstein self-assigned this Jun 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Code reviewed and tested locally -- thank you @andrew-goldstein!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #5 / Hover actions Adds global filter - filter in

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4104 4105 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ecs-data-quality-dashboard 1 5 +4

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
@kbn/ecs-data-quality-dashboard 0 2 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 10.7MB 10.8MB +107.0KB
Unknown metric groups

API count

id before after diff
@kbn/ecs-data-quality-dashboard 9 13 +4

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 413 417 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 497 501 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @andrew-goldstein

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-goldstein andrew-goldstein merged commit 2df8746 into elastic:main Jun 6, 2023
@andrew-goldstein andrew-goldstein deleted the assistant-fixes-main branch June 6, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants