-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Management] Refactor index pattern creation to React, Phase 1 #15905
Closed
chrisronline
wants to merge
8
commits into
elastic:eui/reactify-ipc
from
chrisronline:eui/reactify-ipc-shell
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
69aafca
Improvements to step 1
chrisronline 460020e
Progress
chrisronline bea416f
More progress
chrisronline e4d9916
Out with the old, in with the new
chrisronline 5c633d0
Remove files that will be in a later PR
chrisronline b270d1c
More other code removed
chrisronline 04adebb
Remove dead code
chrisronline 958730d
Split these up
chrisronline File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
...bana/public/management/sections/indices/create_index_pattern_wizard/angular_template.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<kbn-management-app section="kibana"> | ||
<kbn-management-indices> | ||
<div id="react"></div> | ||
</kbn-management-indices> | ||
</kbn-management-app> |
7 changes: 7 additions & 0 deletions
7
.../kibana/public/management/sections/indices/create_index_pattern_wizard/constants/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
// This isn't ideal. We want to avoid searching for 20 indices | ||
// then filtering out the majority of them because they are sysetm indices. | ||
// We'd like to filter system indices out in the query | ||
// so if we can accomplish that in the future, this logic can go away | ||
export const ESTIMATED_NUMBER_OF_SYSTEM_INDICES = 100; | ||
export const MAX_NUMBER_OF_MATCHING_INDICES = 100; | ||
export const MAX_SEARCH_SIZE = MAX_NUMBER_OF_MATCHING_INDICES + ESTIMATED_NUMBER_OF_SYSTEM_INDICES; |
157 changes: 0 additions & 157 deletions
157
.../management/sections/indices/create_index_pattern_wizard/create_index_pattern_wizard.html
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might sound paranoid but to be sure we avoid collisions can we go with a more specific
id
value, e.g. "createIndexPatternWizard"?