-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs+] Replace usages of link-to routes in infra server #158994
[Logs+] Replace usages of link-to routes in infra server #158994
Conversation
π€ GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
Pinging @elastic/apm-ui (Team:APM) |
x-pack/plugins/infra/public/alerting/log_threshold/rule_data_formatters.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/public/alerting/log_threshold/rule_data_formatters.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/public/observability_logs/log_view_state/src/defaults.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/server/services/log_views/log_views_client.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes!
π Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
closes #157985
π Summary
This PR moves the previously implemented infra locators to infra common and replaces the last usage of
link-to
routes in the infra public with the appropriate locator.β Testing
View in app
buttonScreen.Recording.2023-06-06.at.15.35.05.mov