Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs+] Replace usages of link-to routes in infra server #158994

Conversation

mohamedhamed-ahmed
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed commented Jun 4, 2023

closes #157985

πŸ“ Summary

This PR moves the previously implemented infra locators to infra common and replaces the last usage of link-to routes in the infra public with the appropriate locator.

βœ… Testing

  1. Navigate to Observability Alerts
  2. Create a new Log Threshold Rule that should fire
  3. Open the alert details flyout
  4. Click on the View in app button
  5. Should correctly navigate to Stream view or Discover in case of serverless.
  • All other links to Logs should still work properly as before as well
Screen.Recording.2023-06-06.at.15.35.05.mov

@apmmachine
Copy link
Contributor

πŸ€– GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mohamedhamed-ahmed mohamedhamed-ahmed added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.9.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jun 5, 2023
@mohamedhamed-ahmed mohamedhamed-ahmed marked this pull request as ready for review June 6, 2023 15:34
@mohamedhamed-ahmed mohamedhamed-ahmed requested review from a team as code owners June 6, 2023 15:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jun 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes!

@kibana-ci
Copy link
Collaborator

πŸ’š Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1437 1436 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.0MB 2.0MB +4.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 133.8KB 134.8KB +1.0KB
Unknown metric groups

async chunk count

id before after diff
infra 30 28 -2

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 414 418 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 498 502 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mohamedhamed-ahmed mohamedhamed-ahmed merged commit 3785c93 into elastic:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs UI] Replace link-to routes with the appropriate locator
6 participants