-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serverless] Disable Search Sessions #158356
[Serverless] Disable Search Sessions #158356
Conversation
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @ElenaStoeva |
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
@davismcphee one thing to check, I think we're using searchSessions in the unified histogram layout: kibana/src/plugins/discover/public/application/main/components/layout/discover_histogram_layout.tsx Line 36 in 8f41ab0
so the question if this still works, but anyway, it might be better to search for an alternative since I don't think we need the searchSessionManager service anywhere else in the code |
@kertal The main thing we're using it for here is to determine if the first search has run yet when navigating to Discover. If we can find another way to check for this, I think we can likely remove kibana/src/plugins/discover/public/application/main/components/layout/discover_histogram_layout.tsx Lines 47 to 49 in 8f41ab0
Otherwise we may have to check if the search session plugin is enabled and add that to the check as well. Although in either case we'll still need to be able to retrieve the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled and tested locally, and I was unable to access app/management/kibana/search_sessions
as expected. I also did some testing in Discover and everything seems to working fine there as well. LGTM 👍
@kertal It looks like this change just disables the use of search sessions in searches, but the search session service is still available, and it still returns IDs so it doesn't seem to have any impact on Discover from what I can tell.
Thx for checking! |
Thanks a lot for the review @davismcphee and @kertal! |
Partially addresses #157756
Summary
This PR disables the Search Sessions plugin for serverless.
How to test:
yarn es snapshot
and Kibana with yarnserverless-{mode}
where{mode}
can bees
,security
, oroblt
.app/management/kibana/search_sessions
) leads to the Stack Management landing page.