-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profiling] Manage indices via Elasticsearch #157949
[Profiling] Manage indices via Elasticsearch #157949
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
ac3a554
to
7273fd9
Compare
1798b6e
to
3f7e318
Compare
const isProfilingTemplatesEnabled = | ||
settings.persistent.xpack?.profiling?.templates?.enabled ?? false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check can likely be replaced by querying the new status API after it is merged.
The latest Cypress tests fail with the following error:
@inge4pres @florianl Is this error related to the configuration in |
maybe @joshdover or @kpollich can tell more about this error? The package profiler_symbolizer exists now for some time and wasn't touched since its creation. And the bundling with kibana did also not change: Lines 43 to 48 in 9d02c63
|
b35cec8
to
cfa7b90
Compare
To understand the error, the code around here is key:
|
Pinging @elastic/fleet (Team:Fleet) |
With the following command I verified that the package is available:
Not sure where and why it fails here. |
976143a
to
246c027
Compare
Yes, the point is that the This corrects the URL, but then the tests the fail later on, not sure if that is related to UP.
Maybe someone knows how to set |
543aa59
to
92092ee
Compare
I found out today that the Unfortunately one of the UI tests is failing after I fixed several things, but at least we have progress. I worked on these today:
Here's what left to do next week:
|
Setting up Elasticsearch and Fleet resources is an asynchronous task. We need to wait until Elasticsearch has created the required indices. To indicate this to the user, we return a 202 Accepted response.
This allows for more ergonomic namespacing in SetupState and gives us a natural way to extend the interface with more properties in the future.
893bb75
to
43f4404
Compare
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @inge4pres |
## Summary This PR addresses two bugs discovered after #157949: * when setting up security roles, the incorrect status was set * when merging the statuses of all steps, the merged status could lose some statuses
Summary
This PR sets up the profiling indices via Elasticsearch instead of using the single-click installation in Kibana.
Notable changes
xpack.profiling.templates.enabled
) totrue
so that indices are bootstrapped in Elasticsearch