Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] use event to use current user and not kibana system #157907

Merged
merged 2 commits into from
May 16, 2023
Merged

[Security Solution] use event to use current user and not kibana system #157907

merged 2 commits into from
May 16, 2023

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented May 16, 2023 •
edited by kibanamachine
Loading

FIX #157882

Security solution user needs to use the current user instead of using kibana system user to fetch alert.

@michaelolo24 will push a follow up PR to write unit test so nobody can change this value anymore!!!

@XavierM XavierM added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Team:Threat Hunting:Investigations Security Solution Investigations Team v8.8.0 v8.9.0 labels May 16, 2023
@XavierM XavierM force-pushed the fix-alert-7-x-flyout branch from 715364e to 3a018bd Compare May 16, 2023 16:56
@XavierM XavierM changed the base branch from 8.8 to main May 16, 2023 16:57
@XavierM XavierM requested a review from a team as a code owner May 16, 2023 16:57
michaelolo24
michaelolo24 approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Xavier! 😄

@XavierM
Copy link
Contributor Author

XavierM commented May 16, 2023

@elasticmachine merge upstream

@XavierM XavierM changed the title use event to use current user and not kibana system [Security Solution] use event to use current user and not kibana system May 16, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 6733497 into elastic:main May 16, 2023
@kibanamachine kibanamachine mentioned this pull request May 16, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 16, 2023
@XavierM
[Security Solution] use event to use current user and not kibana syst…
078eca4 
…em (elastic#157907)

FIX elastic#157882

Security solution user needs to use the current user instead of using
kibana system user to fetch alert.

@michaelolo24 will push a follow up PR to write unit test so nobody can
change this value anymore!!!

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 6733497)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@michaelolo24 michaelolo24 mentioned this pull request May 16, 2023
Merged
@michaelolo24
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

michaelolo24 pushed a commit to michaelolo24/kibana that referenced this pull request May 16, 2023
@XavierM
[Security Solution] use event to use current user and not kibana syst…
24072e8 
…em (elastic#157907)

FIX elastic#157882

Security solution user needs to use the current user instead of using
kibana system user to fetch alert.

@michaelolo24 will push a follow up PR to write unit test so nobody can
change this value anymore!!!

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 6733497)
michaelolo24 added a commit that referenced this pull request May 17, 2023
@michaelolo24 @XavierM
[8.8] [Security Solution] use event to use current user and not kiban…
d642641 
…a system (#157907) (#157943)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] use event to use current user and not kibana
system (#157907)](#157907)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Xavier
Mouligneau","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-16T19:27:46Z","message":"[Security
Solution] use event to use current user and not kibana system
(#157907)\n\nFIX
https://github.com/elastic/kibana/issues/157882\r\n\r\nSecurity solution
user needs to use the current user instead of using\r\nkibana system
user to fetch alert.\r\n\r\n@michaelolo24 will push a follow up PR to
write unit test so nobody can\r\nchange this value
anymore!!!\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"673349718ef114356c4aeaabd69f3c2caa24f553","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","impact:critical","Team:Threat
Hunting:Investigations","v8.8.0","v8.9.0"],"number":157907,"url":"https://github.com/elastic/kibana/pull/157907","mergeCommit":{"message":"[Security
Solution] use event to use current user and not kibana system
(#157907)\n\nFIX
https://github.com/elastic/kibana/issues/157882\r\n\r\nSecurity solution
user needs to use the current user instead of using\r\nkibana system
user to fetch alert.\r\n\r\n@michaelolo24 will push a follow up PR to
write unit test so nobody can\r\nchange this value
anymore!!!\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"673349718ef114356c4aeaabd69f3c2caa24f553"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/157927","number":157927,"state":"OPEN"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157907","number":157907,"mergeCommit":{"message":"[Security
Solution] use event to use current user and not kibana system
(#157907)\n\nFIX
https://github.com/elastic/kibana/issues/157882\r\n\r\nSecurity solution
user needs to use the current user instead of using\r\nkibana system
user to fetch alert.\r\n\r\n@michaelolo24 will push a follow up PR to
write unit test so nobody can\r\nchange this value
anymore!!!\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"673349718ef114356c4aeaabd69f3c2caa24f553"}}]}]
BACKPORT-->

Co-authored-by: Xavier Mouligneau <[email protected]>
kibanamachine added a commit that referenced this pull request May 17, 2023
@kibanamachine @XavierM
[8.8] [Security Solution] use event to use current user and not kiban…
1ea2bd7 
…a system (#157907) (#157927)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] use event to use current user and not kibana
system (#157907)](#157907)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Xavier
Mouligneau","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-16T19:27:46Z","message":"[Security
Solution] use event to use current user and not kibana system
(#157907)\n\nFIX
https://github.com/elastic/kibana/issues/157882\r\n\r\nSecurity solution
user needs to use the current user instead of using\r\nkibana system
user to fetch alert.\r\n\r\n@michaelolo24 will push a follow up PR to
write unit test so nobody can\r\nchange this value
anymore!!!\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"673349718ef114356c4aeaabd69f3c2caa24f553","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","impact:critical","Team:Threat
Hunting:Investigations","v8.8.0","v8.9.0"],"number":157907,"url":"https://github.com/elastic/kibana/pull/157907","mergeCommit":{"message":"[Security
Solution] use event to use current user and not kibana system
(#157907)\n\nFIX
https://github.com/elastic/kibana/issues/157882\r\n\r\nSecurity solution
user needs to use the current user instead of using\r\nkibana system
user to fetch alert.\r\n\r\n@michaelolo24 will push a follow up PR to
write unit test so nobody can\r\nchange this value
anymore!!!\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"673349718ef114356c4aeaabd69f3c2caa24f553"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157907","number":157907,"mergeCommit":{"message":"[Security
Solution] use event to use current user and not kibana system
(#157907)\n\nFIX
https://github.com/elastic/kibana/issues/157882\r\n\r\nSecurity solution
user needs to use the current user instead of using\r\nkibana system
user to fetch alert.\r\n\r\n@michaelolo24 will push a follow up PR to
write unit test so nobody can\r\nchange this value
anymore!!!\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"673349718ef114356c4aeaabd69f3c2caa24f553"}}]}]
BACKPORT-->

Co-authored-by: Xavier Mouligneau <[email protected]>
jasonrhodes pushed a commit that referenced this pull request May 17, 2023
@XavierM @kibanamachine @jasonrhodes
[Security Solution] use event to use current user and not kibana syst…
46d3966 
…em (#157907)

FIX #157882

Security solution user needs to use the current user instead of using
kibana system user to fetch alert.

@michaelolo24 will push a follow up PR to write unit test so nobody can
change this value anymore!!!

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
4 participants
@XavierM @kibana-ci @kibanamachine @michaelolo24