[Security Solution][Endpoint][Response Actions] Fix expand details tray #157896
Conversation
Fixes the bug when sometimes the expanding tray breaks the page on response actions history page/flyout refs elastic/security-team/issues/6603
ashokaditya
added
release_note:skip
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
|
Checked it out and tried it. I'm able to expand/collapse on Endpoint flyout 
I'm able to expand/collapse on Response log page 
|
| @@ -40,6 +40,7 @@ export const useGetEndpointActionList = ( | |||
| return useQuery<ActionListApiResponse, IHttpFetchError<ErrorType>>({ | |||
| queryKey: ['get-action-list', query], | |||
| ...options, | |||
| keepPreviousData: true, | |||
There was a problem hiding this comment.
I'm approving, but am wondering if this has any broader impact?
The docs say this for this option:
If set, any previous data will be kept when fetching new data because the query key changed.
There was a problem hiding this comment.
One way to test might be to expand the row on the page. Then refresh the browser tab - I think we maintain state in the URL, so on a tab refresh there should be nothing for react-query to keepPreviousData
There was a problem hiding this comment.
I tested this scenario.
- Expand rows on page
- Refresh browser
- See it render as expected with trays expanded from the state in browser
|
Hey, I've just played with the issue, and I am not sure if this is the way. I mean, ok to some extend it helps, but the main issue is that we do not have items/action and it crashes at the destructuring. What do you think? |
As we discussed offline, this change in addition to what Ash has already pushed would help further. However, it changes the way the UX around maintaining expanded trays and the overall rendering of the table works, so we'll just merge this change as is since it fixes the problem with expanding trays as we saw earlier. We'll fix the paging issue with this PR: #157777 |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @ashokaditya |
…ay (elastic#157896) ## Summary Fixes the bug when sometimes the expanding tray breaks the page on the response actions history page/flyout It doesn't fix the other issues where when a tray is expanded and paging is used the page breaks. That is being worked on in elastic/pull/157777 ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 8210806)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…ils tray (#157896) (#157910) # Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution][Endpoint][Response Actions] Fix expand details tray (#157896)](#157896) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ashokaditya","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-16T17:36:54Z","message":"[Security Solution][Endpoint][Response Actions] Fix expand details tray (#157896)\n\n## Summary\r\n\r\nFixes the bug when sometimes the expanding tray breaks the page on the\r\nresponse actions history page/flyout\r\n\r\nIt doesn't fix the other issues where when a tray is expanded and paging\r\nis used the page breaks.\r\nThat is being worked on in /pull/157777\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"82108060e7c3794add5687761cf65890dc39d573","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","OLM Sprint","v8.8.0","v8.9.0"],"number":157896,"url":"https://github.com/elastic/kibana/pull/157896","mergeCommit":{"message":"[Security Solution][Endpoint][Response Actions] Fix expand details tray (#157896)\n\n## Summary\r\n\r\nFixes the bug when sometimes the expanding tray breaks the page on the\r\nresponse actions history page/flyout\r\n\r\nIt doesn't fix the other issues where when a tray is expanded and paging\r\nis used the page breaks.\r\nThat is being worked on in /pull/157777\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"82108060e7c3794add5687761cf65890dc39d573"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157896","number":157896,"mergeCommit":{"message":"[Security Solution][Endpoint][Response Actions] Fix expand details tray (#157896)\n\n## Summary\r\n\r\nFixes the bug when sometimes the expanding tray breaks the page on the\r\nresponse actions history page/flyout\r\n\r\nIt doesn't fix the other issues where when a tray is expanded and paging\r\nis used the page breaks.\r\nThat is being worked on in /pull/157777\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"82108060e7c3794add5687761cf65890dc39d573"}}]}] BACKPORT--> Co-authored-by: Ashokaditya <[email protected]>
…ay (#157896) ## Summary Fixes the bug when sometimes the expanding tray breaks the page on the response actions history page/flyout It doesn't fix the other issues where when a tray is expanded and paging is used the page breaks. That is being worked on in /pull/157777 ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Summary
Fixes the bug when sometimes the expanding tray breaks the page on the response actions history page/flyout
It doesn't fix the other issues where when a tray is expanded and paging is used the page breaks.
That is being worked on in /pull/157777
Checklist