[Serverless] Disable Migrate plugin #157881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElenaStoeva
added
the
Team:Kibana Management
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
ElenaStoeva
added
the
release_note:skip
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @ElenaStoeva |
|
Thanks for the review @claracruz! On another note, are you aware of any other plugins/places in Kibana that have links to the Migrate plugin? I didn't find any dependencies, but wanted to check with you to make sure. |
kibanamachine
added
v8.9.0
backport:skip
5 tasks
There shouldn't be any dependencies. Thanks for checking! |
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
May 25, 2023
## Summary This PR makes the Migrate plugin disable-able for serverless. Partially addresses elastic#157756 **How to test:** 1. Start Elasticsearch with `yarn es snapshot` and Kibana with yarn `serverless-{mode}` where `{mode}` can be `es`, `security`, or `oblt`. 2. Verify that the Migrate plugin doesn't show up in the nav bar and its path (`management/data/migrate_data`) leads to the Stack Management landing page. --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the Migrate plugin disable-able for serverless.
Partially addresses #157756
How to test:
yarn es snapshotand Kibana with yarnserverless-{mode}where{mode}can bees,security, oroblt.management/data/migrate_data) leads to the Stack Management landing page.