Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shared hooks and components to Observability Shared #157849

Merged
merged 1 commit into from
May 16, 2023

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented May 16, 2023

Resolves #157848

📝 Summary

This PR copies hooks and components that are used in multiple Observability apps to the Observability Shared plugin.

In upcoming PRs we will update the imports in Obs apps to their new location in Obs Shared. Then finally, when all apps are updated, we will remove the ones in Observability.

More information in the ticket description.

✅ Acceptance criteria

  • Everything should work as before.

@CoenWarmer CoenWarmer requested a review from a team as a code owner May 16, 2023 10:41
@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label May 16, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer force-pushed the chore/prep-observability-shared branch from 155f741 to a34c12e Compare May 16, 2023 11:08
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@CoenWarmer CoenWarmer enabled auto-merge (squash) May 16, 2023 11:52
@CoenWarmer CoenWarmer merged commit d41e921 into elastic:main May 16, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityShared 109 121 +12

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observabilityShared 216 265 +49

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityShared 34.5KB 35.9KB +1.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityShared 37.3KB 41.5KB +4.2KB
Unknown metric groups

API count

id before after diff
observabilityShared 217 266 +49

async chunk count

id before after diff
observabilityShared 2 3 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
observabilityShared 6 7 +1
securitySolution 400 404 +4
total +7

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
observabilityShared 6 7 +1
securitySolution 480 484 +4
total +7

History

  • 💔 Build #128134 failed 155f74120af06be3d88f3498e8acfb678f8b2cd2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move shared hooks and components to Observability Shared
5 participants