[D4C] fix to targetFilePath/processExecutable regex, and null check #157771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitodrummer
added
bug
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 15, 2023
…lastic#157771) ## Summary Fixes the path regex to allow /* and /** values, also fixed a null pointer in yaml editor. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 92600a4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 15, 2023
…heck (#157771) (#157797) # Backport This will backport the following commits from `main` to `8.8`: - [[D4C] fix to targetFilePath/processExecutable regex, and null check (#157771)](#157771) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Karl Godard","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-15T20:00:23Z","message":"[D4C] fix to targetFilePath/processExecutable regex, and null check (#157771)\n\n## Summary\r\n\r\nFixes the path regex to allow /* and /** values, also fixed a null\r\npointer in yaml editor.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"92600a4fbf26e3cd56a2822f8dcda07ea45f4d9d","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","backport:prev-minor","Team: Cloud Native Integrations","v8.8.0","v8.9.0"],"number":157771,"url":"https://github.com/elastic/kibana/pull/157771","mergeCommit":{"message":"[D4C] fix to targetFilePath/processExecutable regex, and null check (#157771)\n\n## Summary\r\n\r\nFixes the path regex to allow /* and /** values, also fixed a null\r\npointer in yaml editor.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"92600a4fbf26e3cd56a2822f8dcda07ea45f4d9d"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157771","number":157771,"mergeCommit":{"message":"[D4C] fix to targetFilePath/processExecutable regex, and null check (#157771)\n\n## Summary\r\n\r\nFixes the path regex to allow /* and /** values, also fixed a null\r\npointer in yaml editor.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"92600a4fbf26e3cd56a2822f8dcda07ea45f4d9d"}}]}] BACKPORT--> Co-authored-by: Karl Godard <[email protected]>
jasonrhodes
pushed a commit
that referenced
this pull request
May 17, 2023
…157771) ## Summary Fixes the path regex to allow /* and /** values, also fixed a null pointer in yaml editor. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the path regex to allow /* and /** values, also fixed a null pointer in yaml editor.
Checklist